Merge branch 'rspec-empty-line-after-letitbe-ee-spec-services-security' into 'master'

Fix RSpec/EmptyLineAfterFinalLetItBe for ee/spec/services/security

See merge request gitlab-org/gitlab!58323

.rubocop_manual_todo.yml

@@ -592,9 +592,6 @@ RSpec/EmptyLineAfterFinalLetItBe:
     - ee/spec/services/requirements_management/update_requirement_service_spec.rb
     - ee/spec/services/resource_access_tokens/create_service_spec.rb
     - ee/spec/services/resource_access_tokens/revoke_service_spec.rb
-    - ee/spec/services/security/auto_fix_label_service_spec.rb
-    - ee/spec/services/security/store_grouped_scans_service_spec.rb
-    - ee/spec/services/security/store_report_service_spec.rb
     - ee/spec/services/status_page/publish_attachments_service_spec.rb
     - ee/spec/services/status_page/publish_details_service_spec.rb
     - ee/spec/services/status_page/publish_list_service_spec.rb

ee/changelogs/unreleased/rspec-empty-lines-after-letitbe-ee-spec-services-security.yml

+---
+title: Fix RSpec/EmptyLineAfterFinalLetItBe rubocop offenses in ee/spec/services/security
+merge_request: 58323
+author: Abdul Wadood @abdulwd
+type: fixed

ee/spec/services/security/auto_fix_label_service_spec.rb

@@ -8,6 +8,7 @@ RSpec.describe Security::AutoFixLabelService do
 
     let_it_be(:project) { create(:project) }
     let_it_be(:bot) { create(:user, :security_bot) }
+
     let(:label_attributes) { described_class::LABEL_PROPERTIES }
     let(:title) { label_attributes[:title] }
     let(:color) { label_attributes[:color] }

ee/spec/services/security/store_grouped_scans_service_spec.rb

@@ -74,6 +74,7 @@ RSpec.describe Security::StoreGroupedScansService do
         let_it_be(:sast_artifact_1) { create(:ee_ci_job_artifact, :sast, job: create(:ee_ci_build)) }
         let_it_be(:sast_artifact_2) { create(:ee_ci_job_artifact, :sast, job: create(:ee_ci_build)) }
         let_it_be(:sast_artifact_3) { create(:ee_ci_job_artifact, :sast, job: create(:ee_ci_build)) }
+
         let(:scanner_1) { instance_double(::Gitlab::Ci::Reports::Security::Scanner, external_id: 'unknown') }
         let(:scanner_2) { instance_double(::Gitlab::Ci::Reports::Security::Scanner, external_id: 'bandit') }
         let(:scanner_3) { instance_double(::Gitlab::Ci::Reports::Security::Scanner, external_id: 'semgrep') }

ee/spec/services/security/store_report_service_spec.rb

@@ -4,6 +4,7 @@ require 'spec_helper'
 
 RSpec.describe Security::StoreReportService, '#execute' do
   let_it_be(:user) { create(:user) }
+
   let(:artifact) { create(:ee_ci_job_artifact, trait) }
   let(:report_type) { artifact.file_type }
   let(:project) { artifact.project }