Commit 466a7751 authored by Fatih Acet's avatar Fatih Acet

Merge branch 'qa-nightly-59-fix-new-label-button-hit-miss' into 'master'

Fixes "New label" button hit miss

Closes gitlab-org/quality/nightly#59

See merge request gitlab-org/gitlab-ce!24487
parents 10d421be 099613f4
...@@ -163,6 +163,7 @@ export default class LazyLoader { ...@@ -163,6 +163,7 @@ export default class LazyLoader {
img.removeAttribute('data-src'); img.removeAttribute('data-src');
img.classList.remove('lazy'); img.classList.remove('lazy');
img.classList.add('js-lazy-loaded'); img.classList.add('js-lazy-loaded');
img.classList.add('qa-js-lazy-loaded');
} }
} }
} }
.row.empty-state.labels .row.empty-state.labels
.col-12 .col-12
.svg-content .svg-content.qa-label-svg
= image_tag 'illustrations/labels.svg' = image_tag 'illustrations/labels.svg'
.col-12 .col-12
.text-content .text-content
......
...@@ -6,7 +6,22 @@ module QA ...@@ -6,7 +6,22 @@ module QA
element :label_create_new element :label_create_new
end end
view 'app/views/shared/empty_states/_labels.html.haml' do
element :label_svg
end
view 'app/assets/javascripts/lazy_loader.js' do
element :js_lazy_loaded
end
def go_to_new_label def go_to_new_label
# The 'labels.svg' takes a fraction of a second to load after which the "New label" button shifts up a bit
# This can cause webdriver to miss the hit so we wait for the svg to load (implicitly with has_element?)
# before clicking the button.
within_element(:label_svg) do
has_element?(:js_lazy_loaded)
end
click_element :label_create_new click_element :label_create_new
end end
end end
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment