Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
46c2151e
Commit
46c2151e
authored
Jun 15, 2021
by
Sanad Liaquat
Committed by
Albert Salim
Jun 15, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Move reviewer roulette table above and improve text
parent
be5b37da
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
24 additions
and
9 deletions
+24
-9
danger/roulette/Dangerfile
danger/roulette/Dangerfile
+24
-9
No files found.
danger/roulette/Dangerfile
View file @
46c2151e
...
...
@@ -2,15 +2,21 @@
require
'digest/md5'
MESSAGE
=
<<
MARKDOWN
REVIEW_ROULETTE_SECTION
=
<<
MARKDOWN
## Reviewer roulette
MARKDOWN
CATEGORY_TABLE
=
<<
MARKDOWN
Changes that require review have been detected!
Changes that require review have been detected! A merge request is normally
reviewed by both a reviewer and a maintainer in its primary category (e.g.
~frontend or ~backend), and by a maintainer in all other categories.
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
| Category | Reviewer | Maintainer |
| -------- | -------- | ---------- |
MARKDOWN
CATEGORY_TABLE_HEADER
=
<<
MARKDOWN
POST_TABLE_MESSAGE
=
<<
MARKDOWN
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each
review slot, based on their timezone. Feel free to
...
...
@@ -26,12 +32,15 @@ Please consider assigning a reviewer or maintainer who is a
Once you've decided who will review this merge request, assign them as a reviewer!
Danger does not automatically notify them for you.
MARKDOWN
| Category | Reviewer | Maintainer |
| -------- | -------- | ---------- |
NO_SUGGESTIONS
=
<<
MARKDOWN
There are no reviewer and maintainer suggestions for the changes in this MR.
MARKDOWN
UNKNOWN_FILES_MESSAGE
=
<<
MARKDOWN
### Uncategorised files
These files couldn't be categorised, so Danger was unable to suggest a reviewer.
Please consider creating a merge request to
...
...
@@ -99,8 +108,14 @@ if changes.any?
markdown_row_for_spins
(
spin
.
category
,
[
spin
])
end
markdown
(
MESSAGE
)
markdown
(
CATEGORY_TABLE_HEADER
+
rows
.
join
(
"
\n
"
))
unless
rows
.
empty?
markdown
(
REVIEW_ROULETTE_SECTION
)
if
rows
.
empty?
markdown
(
NO_SUGGESTIONS
)
else
markdown
(
CATEGORY_TABLE
+
rows
.
join
(
"
\n
"
))
markdown
(
POST_TABLE_MESSAGE
)
end
unknown
=
changes
.
fetch
(
:unknown
,
[])
markdown
(
UNKNOWN_FILES_MESSAGE
+
helper
.
markdown_list
(
unknown
))
unless
unknown
.
empty?
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment