hide labels from filtered search boards, some CSS fixes

app/assets/javascripts/boards/boards_bundle.js

@@ -104,6 +104,8 @@ $(() => {
         if (labelIndex === -1) {
           filterPath.push(param);
         }
+
+        this.cantEdit.push('label');
       });
 
       Store.filter.path = filterPath.join('&');

app/assets/javascripts/boards/components/milestone_select.vue

@@ -41,7 +41,7 @@ export default {
       return this.board.milestone ? this.board.milestone.id : '';
     },
     milestoneTitleClass() {
-      return this.milestoneTitle === 'ANY_MILESTONE' ? 'bold' : 'text-secondary';
+      return this.milestoneTitle === 'ANY_MILESTONE' ? 'text-secondary': 'bold';
     },
     selected() {
       return this.board.milestone ? this.board.milestone.name : '';

app/assets/stylesheets/framework/dropdowns.scss

@@ -291,10 +291,6 @@
   }
 }
 
-.dropdown-menu-wide {
-  width: 100%;
-}
-
 .droplab-dropdown {
   .dropdown-toggle > i {
     pointer-events: none;

app/assets/stylesheets/framework/lists.scss

@@ -393,5 +393,9 @@ ul.indent-list {
 
 .list-item {
   padding: $gl-padding 0;
-  border-bottom: solid 1px $border-color;
+
+  // add a border between all items, but not at the start or end
+  + .list-item {
+    border-top: solid 1px $border-color;
+  }
 }

app/assets/stylesheets/framework/modal.scss

@@ -40,12 +40,6 @@ body.modal-open {
   max-width: 440px;
 }
 
-.modal-dialog {
-  // TODO: this needs top and bottom padding (inside content area)
-  max-height: calc(100vh - #{$new-navbar-height});
-  padding: $gl-padding;
-}
-
 .modal.popup-dialog {
   display: block;