Use applogger in ee/app/helpers, models and services

changelogs/unreleased/app-logger-3.yml

+---
+title: Use applogger in ee/app/models, helpers and workers
+merge_request: 41048
+author: Rajendra Kadam
+type: other

ee/app/helpers/ee/kerberos_spnego_helper.rb

@@ -82,7 +82,7 @@ module EE
       # Return user principal name if authentication succeeded
       gss.display_name
     rescue GSSAPI::GssApiError => ex
-      Rails.logger.error "#{self.class.name}: failed to process Negotiate/Kerberos authentication: #{ex.message}" # rubocop:disable Gitlab/RailsLogger
+      Gitlab::AppLogger.error "#{self.class.name}: failed to process Negotiate/Kerberos authentication: #{ex.message}"
       false
     end
 

ee/app/models/geo_node.rb

@@ -232,7 +232,7 @@ class GeoNode < ApplicationRecord
     # be called in an initializer and we don't want other callbacks
     # to mess with uninitialized dependencies.
     if clone_url_prefix_changed?
-      Rails.logger.info "Geo: modified clone_url_prefix to #{clone_url_prefix}" # rubocop:disable Gitlab/RailsLogger
+      Gitlab::AppLogger.info "Geo: modified clone_url_prefix to #{clone_url_prefix}"
       update_column(:clone_url_prefix, clone_url_prefix)
     end
   end

ee/app/services/fetch_subscription_plans_service.rb

@@ -21,7 +21,7 @@ class FetchSubscriptionPlansService
 
     Gitlab::Json.parse(response.body).map { |plan| Hashie::Mash.new(plan) }
   rescue => e
-    Rails.logger.info "Unable to connect to GitLab Customers App #{e}" # rubocop:disable Gitlab/RailsLogger
+    Gitlab::AppLogger.info "Unable to connect to GitLab Customers App #{e}"
 
     nil
   end

ee/app/workers/ldap_sync_worker.rb

@@ -8,18 +8,16 @@ class LdapSyncWorker # rubocop:disable Scalability/IdempotentWorker
   worker_has_external_dependencies!
 
   # rubocop: disable CodeReuse/ActiveRecord
-  # rubocop: disable Gitlab/RailsLogger
   def perform
     return unless Gitlab::Auth::Ldap::Config.group_sync_enabled?
 
-    Rails.logger.info "Performing daily LDAP sync task."
+    Gitlab::AppLogger.info "Performing daily LDAP sync task."
     User.ldap.find_each(batch_size: 100).each do |ldap_user|
-      Rails.logger.debug "Syncing user #{ldap_user.username}, #{ldap_user.email}"
+      Gitlab::AppLogger.debug "Syncing user #{ldap_user.username}, #{ldap_user.email}"
       # Use the 'update_ldap_group_links_synchronously' option to avoid creating a ton
       # of new Sidekiq jobs all at once.
       Gitlab::Auth::Ldap::Access.allowed?(ldap_user, update_ldap_group_links_synchronously: true)
     end
   end
   # rubocop: enable CodeReuse/ActiveRecord
-  # rubocop: enable Gitlab/RailsLogger
 end

ee/app/workers/pseudonymizer_worker.rb

@@ -21,7 +21,7 @@ class PseudonymizerWorker # rubocop:disable Scalability/IdempotentWorker
     uploader = Pseudonymizer::Uploader.new(options, progress_output: File.open(File::NULL, "w"))
 
     unless uploader.available?
-      Rails.logger.error("The pseudonymizer object storage must be configured.") # rubocop:disable Gitlab/RailsLogger
+      Gitlab::AppLogger.error("The pseudonymizer object storage must be configured.")
       return
     end
 

ee/spec/services/fetch_subscription_plans_service_spec.rb

@@ -26,7 +26,7 @@ RSpec.describe FetchSubscriptionPlansService do
       end
 
       it 'logs failure' do
-        expect(Rails).to receive_message_chain(:logger, :info).with('Unable to connect to GitLab Customers App Error message')
+        expect(Gitlab::AppLogger).to receive(:info).with('Unable to connect to GitLab Customers App Error message')
 
         subject
       end