Automatic merge of gitlab-org/gitlab-ce master

app/assets/javascripts/jobs/components/commit_block.vue

@@ -39,7 +39,7 @@ export default {
       </gl-link>
 
       <clipboard-button
-        :text="commit.short_id"
+        :text="commit.id"
         :title="__('Copy commit SHA to clipboard')"
         css-class="btn btn-clipboard btn-transparent"
       />

changelogs/unreleased/MaxWinterstein-master-patch-23232.yml

+---
+title: Unify behaviour of 'Copy commit SHA to clipboard' to use full commit SHA.
+merge_request: 25829
+author: Max Winterstein
+type: changed

lib/gitlab/danger/helper.rb

@@ -108,7 +108,23 @@ module Gitlab
         %r{\A(ee/)?public/} => :frontend,
         %r{\A(ee/)?spec/(javascripts|frontend)/} => :frontend,
         %r{\A(ee/)?vendor/assets/} => :frontend,
-        %r{\A(jest\.config\.js|package\.json|yarn\.lock|\.eslintrc\.yml)\z} => :frontend,
+        %r{\Ascripts/frontend/} => :frontend,
+        %r{(\A|/)(
+          \.babelrc |
+          \.eslintignore |
+          \.eslintrc(\.yml)? |
+          \.nvmrc |
+          \.prettierignore |
+          \.prettierrc |
+          \.scss-lint.yml |
+          \.stylelintrc |
+          babel\.config\.js |
+          jest\.config\.js |
+          karma\.config\.js |
+          webpack\.config\.js |
+          package\.json |
+          yarn\.lock
+        )\z}x => :frontend,
 
         %r{\A(ee/)?app/(?!assets|views)[^/]+} => :backend,
         %r{\A(ee/)?(bin|config|danger|generator_templates|lib|rubocop|scripts)/} => :backend,

spec/javascripts/jobs/components/commit_block_spec.js

@@ -9,6 +9,7 @@ describe('Commit block', () => {
   const props = {
     commit: {
       short_id: '1f0fb84f',
+      id: '1f0fb84fb6770d74d97eee58118fd3909cd4f48c',
       commit_path: 'commit/1f0fb84fb6770d74d97eee58118fd3909cd4f48c',
       title: 'Update README.md',
     },
@@ -42,7 +43,7 @@ describe('Commit block', () => {
 
     it('renders clipboard button', () => {
       expect(vm.$el.querySelector('button').getAttribute('data-clipboard-text')).toEqual(
-        props.commit.short_id,
+        props.commit.id,
       );
     });
   });