Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
4bfc431f
Commit
4bfc431f
authored
Aug 17, 2020
by
Mark Chao
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Enable sidekiq versioning
by removing feature flag
parent
82d6547b
Changes
4
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
6 additions
and
20 deletions
+6
-20
changelogs/unreleased/232934-sidekiq-versioning-flag.yml
changelogs/unreleased/232934-sidekiq-versioning-flag.yml
+5
-0
config/feature_flags/development/sidekiq_versioning.yml
config/feature_flags/development/sidekiq_versioning.yml
+0
-7
lib/gitlab/sidekiq_versioning/middleware.rb
lib/gitlab/sidekiq_versioning/middleware.rb
+1
-1
spec/lib/gitlab/sidekiq_versioning/middleware_spec.rb
spec/lib/gitlab/sidekiq_versioning/middleware_spec.rb
+0
-12
No files found.
changelogs/unreleased/232934-sidekiq-versioning-flag.yml
0 → 100644
View file @
4bfc431f
---
title
:
Provide versioning support to Sidekiq workers
merge_request
:
39562
author
:
type
:
other
config/feature_flags/development/sidekiq_versioning.yml
deleted
100644 → 0
View file @
82d6547b
---
name
:
sidekiq_versioning
introduced_by_url
:
rollout_issue_url
:
https://gitlab.com/gitlab-org/gitlab/-/issues/232934
group
:
group::fulfillment
type
:
development
default_enabled
:
false
\ No newline at end of file
lib/gitlab/sidekiq_versioning/middleware.rb
View file @
4bfc431f
...
@@ -4,7 +4,7 @@ module Gitlab
...
@@ -4,7 +4,7 @@ module Gitlab
module
SidekiqVersioning
module
SidekiqVersioning
class
Middleware
class
Middleware
def
call
(
worker
,
job
,
queue
)
def
call
(
worker
,
job
,
queue
)
worker
.
job_version
=
job
[
'version'
]
if
worker
.
is_a?
(
ApplicationWorker
)
&&
Feature
.
enabled?
(
:sidekiq_versioning
)
worker
.
job_version
=
job
[
'version'
]
if
worker
.
is_a?
(
ApplicationWorker
)
yield
yield
end
end
...
...
spec/lib/gitlab/sidekiq_versioning/middleware_spec.rb
View file @
4bfc431f
...
@@ -44,17 +44,5 @@ RSpec.describe Gitlab::SidekiqVersioning::Middleware do
...
@@ -44,17 +44,5 @@ RSpec.describe Gitlab::SidekiqVersioning::Middleware do
expect
{
call!
}.
not_to
raise_error
expect
{
call!
}.
not_to
raise_error
end
end
end
end
context
'when sidekiq_versioning is disabled'
do
before
do
stub_feature_flags
(
sidekiq_versioning:
false
)
end
it
'does not set job_version'
do
expect
(
worker
).
not_to
receive
(
:job_version
=
)
call!
end
end
end
end
end
end
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment