Remove positive tabindexes

tabindexes with values greater than 0 are strongly discouraged
by web accessibility bodies. This commit removes these positive
tabindexes.

https://www.w3.org/TR/wai-aria-practices/#keyboard-interaction-7
https://webaim.org/techniques/keyboard/tabindex

app/views/import/shared/_new_project_form.html.haml

@@ -10,7 +10,7 @@
           .input-group-prepend.flex-shrink-0.has-tooltip{ title: root_url }
             .input-group-text
               = root_url
-          = select_tag :namespace_id, namespaces_options(namespace_id_from(params) || :current_user, display_path: true, extra_group: namespace_id_from(params)), class: 'select2 js-select-namespace block-truncated', tabindex: 1
+          = select_tag :namespace_id, namespaces_options(namespace_id_from(params) || :current_user, display_path: true, extra_group: namespace_id_from(params)), class: 'select2 js-select-namespace block-truncated'
         - else
           .input-group-prepend.static-namespace.has-tooltip{ title: user_url(current_user.username) + '/' }
             .input-group-text.border-0
@@ -18,4 +18,4 @@
           = hidden_field_tag :namespace_id, current_user.namespace_id
   .form-group.col-12.col-sm-6.project-path
     = label_tag :path, _('Project slug'), class: 'label-bold'
-    = text_field_tag :path, @path, placeholder: "my-awesome-project", class: "js-path-name form-control", tabindex: 2, required: true
+    = text_field_tag :path, @path, placeholder: "my-awesome-project", class: "js-path-name form-control", required: true

app/views/layouts/_search.html.haml

@@ -6,7 +6,6 @@
           = search_field_tag 'search', nil, placeholder: _('Search or jump to…'),
                                             class: 'search-input dropdown-menu-toggle no-outline js-search-dashboard-options',
                                             spellcheck: false,
-                                            tabindex: '1',
                                             autocomplete: 'off',
                                             data: { issues_path: issues_dashboard_path,
                                               mr_path: merge_requests_dashboard_path,

app/views/projects/branches/new.html.haml

@@ -26,6 +26,6 @@
         = render 'shared/ref_dropdown', dropdown_class: 'wide'
       .form-text.text-muted Existing branch name, tag, or commit SHA
   .form-actions
-    = button_tag 'Create branch', class: 'gl-button btn btn-success', tabindex: 3
+    = button_tag 'Create branch', class: 'gl-button btn btn-success'
     = link_to 'Cancel', project_branches_path(@project), class: 'gl-button btn btn-cancel'
 %script#availableRefs{ type: "application/json" }= @project.repository.ref_names.to_json.html_safe

app/views/projects/imports/new.html.haml

@@ -16,4 +16,4 @@
   = render "shared/import_form", f: f
 
   .form-actions
-    = f.submit 'Start import', class: "gl-button btn btn-success", tabindex: 4
+    = f.submit 'Start import', class: "gl-button btn btn-success"

app/views/projects/pipeline_schedules/_form.html.haml

@@ -39,5 +39,5 @@
         = f.check_box :active, required: false, value: @schedule.active?
         = f.label :active, _('Active'), class: 'gl-font-weight-normal'
   .footer-block.row-content-block
-    = f.submit _('Save pipeline schedule'), class: 'btn btn-success', tabindex: 3
+    = f.submit _('Save pipeline schedule'), class: 'btn btn-success'
     = link_to _('Cancel'), pipeline_schedules_path(@project), class: 'btn btn-cancel'

app/views/projects/pipelines/new.html.haml

@@ -48,7 +48,7 @@
           = (s_("Pipeline|Specify variable values to be used in this run. The values specified in %{settings_link} will be used by default.") % {settings_link: settings_link}).html_safe
 
     .form-actions
-      = f.submit s_('Pipeline|Run Pipeline'), class: 'btn btn-success js-variables-save-button', tabindex: 3
+      = f.submit s_('Pipeline|Run Pipeline'), class: 'btn btn-success js-variables-save-button'
       = link_to _('Cancel'), project_pipelines_path(@project), class: 'btn btn-default float-right'
 
   %script#availableRefs{ type: "application/json" }= @project.repository.ref_names.to_json.html_safe

app/views/shared/groups/_search_form.html.haml

 = form_tag request.path, method: :get, class: "group-filter-form js-group-filter-form", id: 'group-filter-form' do |f|
-  = search_field_tag :filter, params[:filter], placeholder: s_('GroupsTree|Search by name'), class: 'group-filter-form-field form-control js-groups-list-filter qa-groups-filter', spellcheck: false, id: 'group-filter-form-field', tabindex: "2"
+  = search_field_tag :filter, params[:filter], placeholder: s_('GroupsTree|Search by name'), class: 'group-filter-form-field form-control js-groups-list-filter qa-groups-filter', spellcheck: false, id: 'group-filter-form-field'

app/views/shared/projects/_search_form.html.haml

@@ -7,7 +7,6 @@
     class: "project-filter-form-field form-control #{form_field_classes}",
     spellcheck: false,
     id: 'project-filter-form-field',
-    tabindex: "2",
     autofocus: local_assigns[:autofocus]
 
   - if local_assigns[:icon]

changelogs/unreleased/cngo-remove-positive-tabindexes.yml

+---
+title: Remove positive tabindexes
+merge_request: 46003
+author:
+type: fixed

ee/app/assets/javascripts/boards/components/issue_card_weight.vue

@@ -26,7 +26,6 @@ export default {
     :is="tagName"
     ref="itemWeight"
     class="board-card-info card-number board-card-weight"
-    tabindex="1"
     v-on="$listeners"
   >
     <gl-icon name="weight" class="board-card-info-icon" />