Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
4d26191d
Commit
4d26191d
authored
Oct 30, 2021
by
scootergrisen
Committed by
Jose Ivan Vargas
Oct 30, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove a "to" from string with "to access to"
parent
7810a49f
Changes
4
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
7 additions
and
7 deletions
+7
-7
app/views/admin/application_settings/_performance_bar.html.haml
...ews/admin/application_settings/_performance_bar.html.haml
+1
-1
doc/administration/monitoring/performance/performance_bar.md
doc/administration/monitoring/performance/performance_bar.md
+1
-1
locale/gitlab.pot
locale/gitlab.pot
+1
-1
spec/features/admin/admin_settings_spec.rb
spec/features/admin/admin_settings_spec.rb
+4
-4
No files found.
app/views/admin/application_settings/_performance_bar.html.haml
View file @
4d26191d
...
...
@@ -6,7 +6,7 @@
.form-check
=
f
.
check_box
:performance_bar_enabled
,
class:
'form-check-input'
,
data:
{
qa_selector:
'enable_performance_bar_checkbox'
}
=
f
.
label
:performance_bar_enabled
,
class:
'form-check-label'
do
=
_
(
"Allow non-administrators
to
access to the performance bar"
)
=
_
(
"Allow non-administrators access to the performance bar"
)
.form-group
=
f
.
label
:performance_bar_allowed_group_path
,
_
(
'Allow access to members of the following group'
),
class:
'label-bold'
=
f
.
text_field
:performance_bar_allowed_group_path
,
class:
'form-control gl-form-input'
,
placeholder:
'my-org/my-group'
,
value:
@application_setting
.
performance_bar_allowed_group
&
.
full_path
...
...
doc/administration/monitoring/performance/performance_bar.md
View file @
4d26191d
...
...
@@ -114,7 +114,7 @@ for a given group:
1.
On the left sidebar, select
**Settings > Metrics and profiling**
(
`admin/application_settings/metrics_and_profiling`
), and expand
**Profiling - Performance bar**
.
1.
Click
**Allow non-administrators
to
access to the performance bar**
.
1.
Click
**Allow non-administrators access to the performance bar**
.
1.
In the
**Allow access to members of the following group**
field, provide the full path of the
group allowed to access the performance.
1.
Click
**Save changes**
.
locale/gitlab.pot
View file @
4d26191d
...
...
@@ -3370,7 +3370,7 @@ msgstr ""
msgid "Allow group owners to manage LDAP-related settings"
msgstr ""
msgid "Allow non-administrators
to
access to the performance bar"
msgid "Allow non-administrators access to the performance bar"
msgstr ""
msgid "Allow only the selected protocols to be used for Git access."
...
...
spec/features/admin/admin_settings_spec.rb
View file @
4d26191d
...
...
@@ -491,22 +491,22 @@ RSpec.describe 'Admin updates settings' do
group
=
create
(
:group
)
page
.
within
(
'.as-performance-bar'
)
do
check
'Allow non-administrators
to
access to the performance bar'
check
'Allow non-administrators access to the performance bar'
fill_in
'Allow access to members of the following group'
,
with:
group
.
path
click_on
'Save changes'
end
expect
(
page
).
to
have_content
"Application settings saved successfully"
expect
(
find_field
(
'Allow non-administrators
to
access to the performance bar'
)).
to
be_checked
expect
(
find_field
(
'Allow non-administrators access to the performance bar'
)).
to
be_checked
expect
(
find_field
(
'Allow access to members of the following group'
).
value
).
to
eq
group
.
path
page
.
within
(
'.as-performance-bar'
)
do
uncheck
'Allow non-administrators
to
access to the performance bar'
uncheck
'Allow non-administrators access to the performance bar'
click_on
'Save changes'
end
expect
(
page
).
to
have_content
'Application settings saved successfully'
expect
(
find_field
(
'Allow non-administrators
to
access to the performance bar'
)).
not_to
be_checked
expect
(
find_field
(
'Allow non-administrators access to the performance bar'
)).
not_to
be_checked
expect
(
find_field
(
'Allow access to members of the following group'
).
value
).
to
be_nil
end
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment