Merge branch 'rspec-empty-line-after-letitbe-ee-spec-gitlab-geo' into 'master'

Fix RSpec/EmptyLineAfterFinalLetItBe for ee/spec/lib/gitlab/geo

See merge request gitlab-org/gitlab!58380

.rubocop_manual_todo.yml

@@ -527,16 +527,6 @@ RSpec/EmptyLineAfterFinalLetItBe:
     - ee/spec/lib/gitlab/elastic/document_reference_spec.rb
     - ee/spec/lib/gitlab/elastic/group_search_results_spec.rb
     - ee/spec/lib/gitlab/elastic/project_search_results_spec.rb
-    - ee/spec/lib/gitlab/geo/geo_tasks_spec.rb
-    - ee/spec/lib/gitlab/geo/log_cursor/daemon_spec.rb
-    - ee/spec/lib/gitlab/geo/log_cursor/events/container_repository_updated_event_spec.rb
-    - ee/spec/lib/gitlab/geo/log_cursor/events/design_repository_updated_event_spec.rb
-    - ee/spec/lib/gitlab/geo/log_cursor/events/repositories_changed_event_spec.rb
-    - ee/spec/lib/gitlab/geo/log_cursor/events/repository_created_event_spec.rb
-    - ee/spec/lib/gitlab/geo/log_cursor/events/repository_updated_event_spec.rb
-    - ee/spec/lib/gitlab/geo/replication/base_transfer_spec.rb
-    - ee/spec/lib/gitlab/geo/replication/blob_downloader_spec.rb
-    - ee/spec/lib/gitlab/geo/replication/file_transfer_spec.rb
     - ee/spec/lib/gitlab/git_access_spec.rb
     - ee/spec/lib/gitlab/git_access_wiki_spec.rb
     - ee/spec/lib/gitlab/graphql/aggregations/vulnerability_statistics/lazy_aggregate_spec.rb

ee/changelogs/unreleased/rspec-empty-lines-after-letitbe-ee-spec-lib-gitlab-geo.yml

+---
+title: Fix RSpec/EmptyLineAfterFinalLetItBe rubocop offenses in ee/spec/lib/gitlab/geo
+merge_request: 58380
+author: Abdul Wadood @abdulwd
+type: fixed

ee/spec/lib/gitlab/geo/geo_tasks_spec.rb

@@ -24,6 +24,7 @@ RSpec.describe Gitlab::Geo::GeoTasks do
 
   describe '.set_secondary_as_primary' do
     let_it_be(:primary) { create(:geo_node, :primary) }
+
     let(:secondary) { create(:geo_node) }
 
     before do

ee/spec/lib/gitlab/geo/log_cursor/daemon_spec.rb

@@ -8,6 +8,7 @@ RSpec.describe Gitlab::Geo::LogCursor::Daemon, :clean_gitlab_redis_shared_state
 
   let_it_be(:primary, reload: true) { create(:geo_node, :primary) }
   let_it_be(:secondary, reload: true) { create(:geo_node) }
+
   let(:options) { {} }
 
   subject(:daemon) { described_class.new(options) }

ee/spec/lib/gitlab/geo/log_cursor/events/container_repository_updated_event_spec.rb

@@ -7,6 +7,7 @@ RSpec.describe Gitlab::Geo::LogCursor::Events::ContainerRepositoryUpdatedEvent,
 
   let_it_be(:secondary) { create(:geo_node) }
   let_it_be(:secondary_excludes_all_projects) { create(:geo_node, :selective_sync_excludes_all_projects) }
+
   let(:logger) { Gitlab::Geo::LogCursor::Logger.new(described_class, Logger::INFO) }
   let(:event_log) { create(:geo_event_log, :container_repository_updated_event) }
   let!(:event_log_state) { create(:geo_event_log_state, event_id: event_log.id - 1) }

ee/spec/lib/gitlab/geo/log_cursor/events/design_repository_updated_event_spec.rb

@@ -7,6 +7,7 @@ RSpec.describe Gitlab::Geo::LogCursor::Events::DesignRepositoryUpdatedEvent, :cl
 
   let_it_be(:secondary) { create(:geo_node) }
   let_it_be(:secondary_excludes_all_projects) { create(:geo_node, :selective_sync_excludes_all_projects) }
+
   let(:logger) { Gitlab::Geo::LogCursor::Logger.new(described_class, Logger::INFO) }
   let(:project) { create(:project) }
   let(:design_repository_updated_event) { create(:geo_design_repository_updated_event, project: project) }

ee/spec/lib/gitlab/geo/log_cursor/events/repositories_changed_event_spec.rb

@@ -7,6 +7,7 @@ RSpec.describe Gitlab::Geo::LogCursor::Events::RepositoriesChangedEvent, :clean_
 
   let(:logger) { Gitlab::Geo::LogCursor::Logger.new(described_class, Logger::INFO) }
   let_it_be(:secondary) { create(:geo_node) }
+
   let(:repositories_changed_event) { create(:geo_repositories_changed_event, geo_node: secondary) }
   let(:event_log) { create(:geo_event_log, repositories_changed_event: repositories_changed_event) }
   let!(:event_log_state) { create(:geo_event_log_state, event_id: event_log.id - 1) }

ee/spec/lib/gitlab/geo/log_cursor/events/repository_created_event_spec.rb

@@ -6,6 +6,7 @@ RSpec.describe Gitlab::Geo::LogCursor::Events::RepositoryCreatedEvent, :clean_gi
   include ::EE::GeoHelpers
 
   let_it_be(:secondary) { create(:geo_node) }
+
   let(:logger) { Gitlab::Geo::LogCursor::Logger.new(described_class, Logger::INFO) }
   let(:project) { create(:project) }
   let(:repository_created_event) { create(:geo_repository_created_event, project: project) }

ee/spec/lib/gitlab/geo/log_cursor/events/repository_updated_event_spec.rb

@@ -7,6 +7,7 @@ RSpec.describe Gitlab::Geo::LogCursor::Events::RepositoryUpdatedEvent, :clean_gi
 
   let(:logger) { Gitlab::Geo::LogCursor::Logger.new(described_class, Logger::INFO) }
   let_it_be(:secondary) { create(:geo_node) }
+
   let(:project) { create(:project) }
   let(:repository_updated_event) { create(:geo_repository_updated_event, project: project) }
   let(:event_log) { create(:geo_event_log, repository_updated_event: repository_updated_event) }

ee/spec/lib/gitlab/geo/replication/base_transfer_spec.rb

@@ -97,6 +97,7 @@ RSpec.describe Gitlab::Geo::Replication::BaseTransfer do
 
   describe '#stream_from_primary_to_object_storage' do
     let_it_be(:lfs_object) { create(:lfs_object, :with_file, :correct_oid) }
+
     let(:auth_headers) { { 'Authorization' => 'Bearer 12345' } }
     let(:download_link) { 'http://download.link' }
 

ee/spec/lib/gitlab/geo/replication/blob_downloader_spec.rb

@@ -7,6 +7,7 @@ RSpec.describe Gitlab::Geo::Replication::BlobDownloader do
 
   let_it_be(:primary) { create(:geo_node, :primary) }
   let_it_be(:secondary) { create(:geo_node) }
+
   let(:model_record) { create(:package_file, :npm) }
   let(:replicator) { model_record.replicator }
 

ee/spec/lib/gitlab/geo/replication/file_transfer_spec.rb

@@ -7,6 +7,7 @@ RSpec.describe Gitlab::Geo::Replication::FileTransfer do
 
   let_it_be(:primary_node) { create(:geo_node, :primary) }
   let_it_be(:secondary_node) { create(:geo_node) }
+
   let(:user) { create(:user, :with_avatar) }
   let(:upload) { Upload.find_by(model: user, uploader: 'AvatarUploader') }