Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
4f42ba1c
Commit
4f42ba1c
authored
Nov 05, 2020
by
Tiffany Rea
Committed by
Dan Davison
Nov 05, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove FF toggle logic from test
parent
12de7161
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
13 additions
and
20 deletions
+13
-20
qa/qa/specs/features/browser_ui/4_verify/pipeline/run_pipeline_via_web_only_spec.rb
...er_ui/4_verify/pipeline/run_pipeline_via_web_only_spec.rb
+13
-20
No files found.
qa/qa/specs/features/browser_ui/4_verify/pipeline/run_pipeline_via_web_only_spec.rb
View file @
4f42ba1c
...
...
@@ -2,11 +2,8 @@
module
QA
RSpec
.
describe
'Verify'
do
describe
'Run pipeline'
,
:requires_admin
,
:skip_live_env
do
# [TODO]: Developer to remove :requires_admin and :skip_live_env once FF is removed in https://gitlab.com/gitlab-org/gitlab/-/issues/229632
describe
'Run pipeline'
,
only:
{
subdomain: :staging
}
do
context
'with web only rule'
do
let
(
:feature_flag
)
{
:new_pipeline_form
}
let
(
:job_name
)
{
'test_job'
}
let
(
:project
)
do
Resource
::
Project
.
fabricate_via_api!
do
|
project
|
...
...
@@ -20,33 +17,29 @@ module QA
commit
.
commit_message
=
'Add .gitlab-ci.yml'
commit
.
add_files
(
[
{
file_path:
'.gitlab-ci.yml'
,
content:
<<~
YAML
#{
job_name
}
:
tags:
-
#{
project
.
name
}
script: echo 'OK'
only:
- web
YAML
}
{
file_path:
'.gitlab-ci.yml'
,
content:
<<~
YAML
#{
job_name
}
:
tags:
-
#{
project
.
name
}
script: echo 'OK'
only:
- web
YAML
}
]
)
end
end
before
do
Runtime
::
Feature
.
enable
(
feature_flag
)
# [TODO]: Developer to remove when feature flag is removed
Flow
::
Login
.
sign_in
project
.
visit!
Page
::
Project
::
Menu
.
perform
(
&
:click_ci_cd_pipelines
)
end
after
do
Runtime
::
Feature
.
disable
(
feature_flag
)
# [TODO]: Developer to remove when feature flag is removed
end
it
'can trigger pipeline'
,
testcase:
'https://gitlab.com/gitlab-org/quality/testcases/-/issues/946'
do
Page
::
Project
::
Pipeline
::
Index
.
perform
do
|
index
|
expect
(
index
).
not_to
have_pipeline
# should not auto trigger pipeline
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment