Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
4f961f94
Commit
4f961f94
authored
Mar 01, 2017
by
James Lopez
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Add extra MWBS found after the merge
parent
7584b51c
Changes
5
Hide whitespace changes
Inline
Side-by-side
Showing
5 changed files
with
6 additions
and
6 deletions
+6
-6
doc/api/merge_requests.md
doc/api/merge_requests.md
+1
-1
doc/integration/jenkins.md
doc/integration/jenkins.md
+1
-1
lib/api/v3/merge_requests.rb
lib/api/v3/merge_requests.rb
+2
-2
spec/requests/api/projects_spec.rb
spec/requests/api/projects_spec.rb
+1
-1
spec/services/create_deployment_service_spec.rb
spec/services/create_deployment_service_spec.rb
+1
-1
No files found.
doc/api/merge_requests.md
View file @
4f961f94
...
...
@@ -489,7 +489,7 @@ Parameters:
|
`merge_request_id`
| integer | yes | The ID of the merge request |
|
`merge_commit_message`
| string | no | Custom merge commit message |
|
`should_remove_source_branch`
| boolean | no | Remove the source branch after merge |
|
`merge_when_
build_succeeds`
| boolean | no | Merge when build
succeeds, rather than immediately |
|
`merge_when_
pipeline_succeeds`
| boolean | no | Merge when pipeline
succeeds, rather than immediately |
|
`sha`
| string | no | If present, then this SHA must match the HEAD of the source branch, otherwise the merge will fail |
|
`squash`
| boolean | no | Squash the merge request into a single commit |
...
...
doc/integration/jenkins.md
View file @
4f961f94
...
...
@@ -32,7 +32,7 @@ Create a user or choose an existing user that Jenkins will use to interact
through the GitLab API. This user will need to be a global Admin or added
as a member to each Group/Project. Developer permission is required for reporting
build status. This is because a successful build status can trigger a merge
when 'Merge when
build
succeeds' feature is used. Some features of the GitLab
when 'Merge when
pipeline
succeeds' feature is used. Some features of the GitLab
Plugin may require additional privileges. For example, there is an option to
accept a merge request if the build is successful. Using this feature would
require developer, master or owner-level permission.
...
...
lib/api/v3/merge_requests.rb
View file @
4f961f94
...
...
@@ -179,7 +179,7 @@ module API
optional
:should_remove_source_branch
,
type:
Boolean
,
desc:
'When true, the source branch will be deleted if possible'
optional
:merge_when_build_succeeds
,
type:
Boolean
,
desc:
'When true, this merge request will be merged when the
build
succeeds'
desc:
'When true, this merge request will be merged when the
pipeline
succeeds'
optional
:sha
,
type:
String
,
desc:
'When present, must have the HEAD SHA of the source branch'
optional
:squash
,
type:
Boolean
,
desc:
'When true, the commits will be squashed into a single commit on merge'
end
...
...
@@ -220,7 +220,7 @@ module API
present
merge_request
,
with:
::
API
::
V3
::
Entities
::
MergeRequest
,
current_user:
current_user
,
project:
user_project
end
desc
'Cancel merge if "Merge When
Build
succeeds" is enabled'
do
desc
'Cancel merge if "Merge When
Pipeline
succeeds" is enabled'
do
success
::
API
::
V3
::
Entities
::
MergeRequest
end
post
"
#{
path
}
/cancel_merge_when_build_succeeds"
do
...
...
spec/requests/api/projects_spec.rb
View file @
4f961f94
...
...
@@ -556,7 +556,7 @@ describe API::Projects, api: true do
expect
(
json_response
[
'shared_with_groups'
][
0
][
'group_id'
]).
to
eq
(
group
.
id
)
expect
(
json_response
[
'shared_with_groups'
][
0
][
'group_name'
]).
to
eq
(
group
.
name
)
expect
(
json_response
[
'shared_with_groups'
][
0
][
'group_access_level'
]).
to
eq
(
link
.
group_access
)
expect
(
json_response
[
'only_allow_merge_if_
build_succeeds'
]).
to
eq
(
project
.
only_allow_merge_if_build
_succeeds
)
expect
(
json_response
[
'only_allow_merge_if_
pipeline_succeeds'
]).
to
eq
(
project
.
only_allow_merge_if_pipeline
_succeeds
)
expect
(
json_response
[
'only_allow_merge_if_all_discussions_are_resolved'
]).
to
eq
(
project
.
only_allow_merge_if_all_discussions_are_resolved
)
expect
(
json_response
[
'repository_storage'
]).
to
eq
(
project
.
repository_storage
)
end
...
...
spec/services/create_deployment_service_spec.rb
View file @
4f961f94
...
...
@@ -221,7 +221,7 @@ describe CreateDeploymentService, services: true do
{
environment:
{
name:
'production'
,
url:
'http://gitlab.com'
}
}
end
context
'when
build
succeeds'
do
context
'when
pipeline
succeeds'
do
it_behaves_like
'does create environment and deployment'
do
let
(
:deployable
)
{
build
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment