Commit 50d01d89 authored by Quang-Minh Nguyen's avatar Quang-Minh Nguyen

Move Labkit::Middleware::Rack to the top

Labkit context is essential for our application so that it abtracts
context data passing in different layers of a request lifecyle. Before
this change, there is a middleware that initiates context and setup
collaboration ID. That middleware is unfornuately in the middleware of
the middleware stack. Moving it to the top, right after RequestId
middleware, unlocks some useful use cases for us.

Issue: https://gitlab.com/gitlab-com/gl-infra/scalability/-/issues/1083
Change: changed
parent 532f8b12
......@@ -17,4 +17,4 @@ unless Rails::Configuration::MiddlewareStackProxy.method_defined?(:move)
end
Rails.application.config.middleware.move(1, ActionDispatch::RequestId)
Rails.application.config.middleware.insert_after(ActionDispatch::RequestId, Labkit::Middleware::Rack)
Rails.application.config.middleware.insert(1, Labkit::Middleware::Rack)
......@@ -27,7 +27,7 @@ end
Gitlab::Application.configure do |config|
# 0 should be Sentry to catch errors in this middleware
config.middleware.insert(1, Gitlab::Metrics::RequestsRackMiddleware)
config.middleware.insert_after(Labkit::Middleware::Rack, Gitlab::Metrics::RequestsRackMiddleware)
end
Sidekiq.configure_server do |config|
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment