Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
518af7f2
Commit
518af7f2
authored
May 19, 2021
by
Francisco Javier López
Committed by
charlie ablett
May 19, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove old compatibility class GitGarbageCollectWorker
parent
64cc235e
Changes
4
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
0 additions
and
56 deletions
+0
-56
app/workers/all_queues.yml
app/workers/all_queues.yml
+0
-9
app/workers/git_garbage_collect_worker.rb
app/workers/git_garbage_collect_worker.rb
+0
-19
config/sidekiq_queues.yml
config/sidekiq_queues.yml
+0
-2
spec/workers/git_garbage_collect_worker_spec.rb
spec/workers/git_garbage_collect_worker_spec.rb
+0
-26
No files found.
app/workers/all_queues.yml
View file @
518af7f2
...
...
@@ -2107,15 +2107,6 @@
:idempotent:
true
:tags:
- :exclude_from_kubernetes
-
:name: git_garbage_collect
:worker_name: GitGarbageCollectWorker
:feature_category: :gitaly
:has_external_dependencies:
:urgency: :low
:resource_boundary: :unknown
:weight:
1
:idempotent:
:tags: []
-
:name: github_import_advance_stage
:worker_name: Gitlab::GithubImport::AdvanceStageWorker
:feature_category: :importers
...
...
app/workers/git_garbage_collect_worker.rb
deleted
100644 → 0
View file @
64cc235e
# frozen_string_literal: true
# According to our docs, we can only remove workers on major releases
# https://docs.gitlab.com/ee/development/sidekiq_style_guide.html#removing-workers.
#
# We need to still maintain this until 14.0 but with the current functionality.
#
# In https://gitlab.com/gitlab-org/gitlab/-/issues/299290 we track that removal.
class
GitGarbageCollectWorker
# rubocop:disable Scalability/IdempotentWorker
include
ApplicationWorker
sidekiq_options
retry:
false
feature_category
:gitaly
loggable_arguments
1
,
2
,
3
def
perform
(
project_id
,
task
=
:gc
,
lease_key
=
nil
,
lease_uuid
=
nil
)
::
Projects
::
GitGarbageCollectWorker
.
new
.
perform
(
project_id
,
task
,
lease_key
,
lease_uuid
)
end
end
config/sidekiq_queues.yml
View file @
518af7f2
...
...
@@ -152,8 +152,6 @@
-
1
-
-
geo
-
1
-
-
git_garbage_collect
-
1
-
-
github_import_advance_stage
-
1
-
-
github_importer
...
...
spec/workers/git_garbage_collect_worker_spec.rb
deleted
100644 → 0
View file @
64cc235e
# frozen_string_literal: true
require
'fileutils'
require
'spec_helper'
RSpec
.
describe
GitGarbageCollectWorker
do
let_it_be
(
:project
)
{
create
(
:project
,
:repository
)
}
let
(
:lease_uuid
)
{
SecureRandom
.
uuid
}
let
(
:lease_key
)
{
"project_housekeeping:
#{
project
.
id
}
"
}
let
(
:task
)
{
:full_repack
}
let
(
:params
)
{
[
project
.
id
,
task
,
lease_key
,
lease_uuid
]
}
subject
{
described_class
.
new
}
describe
"#perform"
do
it
'calls the Projects::GitGarbageGitGarbageCollectWorker with the same params'
do
expect_next_instance_of
(
Projects
::
GitGarbageCollectWorker
)
do
|
instance
|
expect
(
instance
).
to
receive
(
:perform
).
with
(
*
params
)
end
subject
.
perform
(
*
params
)
end
end
end
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment