Commit 51ba77d5 authored by Grzegorz Bizon's avatar Grzegorz Bizon

Add a test that fixes Runner -> GitLab API in place

We want to evolve Runner API so we need to make sure that GitLab ignores
fields in a payload that can not be recognized. Runners can get updated
before a new version of GitLab is installed.
parent 9e023666
......@@ -61,6 +61,23 @@ RSpec.describe API::Ci::Runner, :clean_gitlab_redis_shared_state do
expect(response.header).not_to have_key('X-GitLab-Trace-Update-Interval')
end
context 'when runner sends an unrecognized field in a payload' do
##
# This test case is here to ensure that the API used to communicate
# runner with GitLab can evolve.
#
# In case of adding new features on the Runner side we do not want
# GitLab-side to reject requests containing unrecognizable fields in
# a payload, because runners can be updated before a new version of
# GitLab is installed.
#
it 'ignores unrecognized fields' do
update_job(state: 'success', 'unknown': 'something')
expect(job.reload).to be_success
end
end
context 'when failure_reason is script_failure' do
before do
update_job(state: 'failed', failure_reason: 'script_failure')
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment