Refactor codeclimate related code for build and pipeline

Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>

app/models/ci/build.rb

@@ -441,6 +441,11 @@ module Ci
       trace
     end
 
+    def has_codeclimate_json?
+      options.dig(:artifacts, :paths) == ['codeclimate.json'] &&
+        artifacts_metadata?
+    end
+
     private
 
     def update_artifacts_size

app/models/ci/pipeline.rb

@@ -397,10 +397,7 @@ module Ci
     end
 
     def codeclimate_artifact
-      artifacts.codeclimate.find do |artifact|
-        artifact.options[:artifacts][:paths] == ['codeclimate.json'] &&
-          artifact.artifacts_metadata?
-      end
+      artifacts.codeclimate.find(&:has_codeclimate_json?)
     end
 
     private

spec/models/ci/build_spec.rb

@@ -1367,4 +1367,38 @@ describe Ci::Build, :models do
       build.enqueue
     end
   end
+
+  describe '#has_codeclimate_json?' do
+    context 'valid build' do
+      let!(:build) do
+        create(
+          :ci_build,
+          :artifacts,
+          name: 'codeclimate',
+          pipeline: pipeline,
+          options: {
+            artifacts: {
+              paths: ['codeclimate.json']
+            }
+          }
+        )
+      end
+
+      it { expect(build.has_codeclimate_json?).to be_truthy }
+    end
+
+    context 'invalid build' do
+      let!(:build) do
+        create(
+          :ci_build,
+          :artifacts,
+          name: 'codeclimate',
+          pipeline: pipeline,
+          options: {}
+        )
+      end
+
+      it { expect(build.has_codeclimate_json?).to be_falsey }
+    end
+  end
 end

spec/models/ci/pipeline_spec.rb

@@ -1220,22 +1220,28 @@ describe Ci::Pipeline, models: true do
   end
 
   describe '#codeclimate_artifact' do
-    let!(:build) do
-      create(
-        :ci_build,
-        :artifacts,
-        name: 'codeclimate',
-        pipeline: pipeline,
-        options: {
-          artifacts: {
-            paths: ['codeclimate.json']
+    context 'has codeclimate build' do
+      let!(:build) do
+        create(
+          :ci_build,
+          :artifacts,
+          name: 'codeclimate',
+          pipeline: pipeline,
+          options: {
+            artifacts: {
+              paths: ['codeclimate.json']
+            }
           }
-        }
-      )
+        )
+      end
+
+      it { expect(pipeline.codeclimate_artifact).to eq(build) }
     end
 
-    it do
-      expect(pipeline.codeclimate_artifact).to eq(build)
+    context 'no codeclimate build' do
+      before { create(:ci_build, pipeline: pipeline) }
+
+      it { expect(pipeline.codeclimate_artifact).to be_nil }
     end
   end
 end