Merge branch '326058-remove-test-summary-widget-expansions-usage-data-feature-flag' into 'master'

Remove test summary widget usage ping feature flag

See merge request gitlab-org/gitlab!71781

app/assets/javascripts/reports/grouped_test_report/grouped_test_reports_app.vue

@@ -3,7 +3,6 @@ import { GlButton, GlIcon } from '@gitlab/ui';
 import { mapActions, mapGetters, mapState } from 'vuex';
 import api from '~/api';
 import { sprintf, s__ } from '~/locale';
-import glFeatureFlagsMixin from '~/vue_shared/mixins/gl_feature_flags_mixin';
 import GroupedIssuesList from '../components/grouped_issues_list.vue';
 import { componentNames } from '../components/issue_body';
 import ReportSection from '../components/report_section.vue';
@@ -28,7 +27,6 @@ export default {
     GlButton,
     GlIcon,
   },
-  mixins: [glFeatureFlagsMixin()],
   props: {
     endpoint: {
       type: String,
@@ -82,9 +80,7 @@ export default {
   methods: {
     ...mapActions(['setPaths', 'fetchReports', 'closeModal']),
     handleToggleEvent() {
-      if (this.glFeatures.usageDataITestingSummaryWidgetTotal) {
-        api.trackRedisHllUserEvent(this.$options.expandEvent);
-      }
+      api.trackRedisHllUserEvent(this.$options.expandEvent);
     },
     reportText(report) {
       const { name, summary } = report || {};

app/controllers/projects/merge_requests_controller.rb

@@ -37,7 +37,6 @@ class Projects::MergeRequestsController < Projects::MergeRequests::ApplicationCo
     push_frontend_feature_flag(:core_security_mr_widget_counts, @project)
     push_frontend_feature_flag(:paginated_notes, @project, default_enabled: :yaml)
     push_frontend_feature_flag(:confidential_notes, @project, default_enabled: :yaml)
-    push_frontend_feature_flag(:usage_data_i_testing_summary_widget_total, @project, default_enabled: :yaml)
     push_frontend_feature_flag(:improved_emoji_picker, project, default_enabled: :yaml)
     push_frontend_feature_flag(:diffs_virtual_scrolling, project, default_enabled: :yaml)
     push_frontend_feature_flag(:restructured_mr_widget, project, default_enabled: :yaml)

config/feature_flags/development/usage_data_i_testing_summary_widget_total.yml

----
-name: usage_data_i_testing_summary_widget_total
-introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/57543
-rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/326058
-milestone: '13.11'
-type: development
-group: group::testing
-default_enabled: true

lib/gitlab/usage_data_counters/known_events/common.yml

@@ -181,7 +181,6 @@
   category: testing
   redis_slot: testing
   aggregation: weekly
-  feature_flag: usage_data_i_testing_summary_widget_total
 # Project Management group
 - name: g_project_management_issue_title_changed
   category: issues_edit

spec/frontend/reports/grouped_test_report/grouped_test_reports_app_spec.js

@@ -24,7 +24,7 @@ describe('Grouped test reports app', () => {
   let wrapper;
   let mockStore;
 
-  const mountComponent = ({ props = { pipelinePath }, glFeatures = {} } = {}) => {
+  const mountComponent = ({ props = { pipelinePath } } = {}) => {
     wrapper = mount(GroupedTestReportsApp, {
       store: mockStore,
       localVue,
@@ -34,9 +34,6 @@ describe('Grouped test reports app', () => {
         pipelinePath,
         ...props,
       },
-      provide: {
-        glFeatures,
-      },
     });
   };
 
@@ -114,8 +111,8 @@ describe('Grouped test reports app', () => {
       setReports(newFailedTestReports);
     });
 
-    it('tracks service ping metric when enabled', () => {
-      mountComponent({ glFeatures: { usageDataITestingSummaryWidgetTotal: true } });
+    it('tracks service ping metric', () => {
+      mountComponent();
       findExpandButton().trigger('click');
 
       expect(Api.trackRedisHllUserEvent).toHaveBeenCalledTimes(1);
@@ -123,7 +120,7 @@ describe('Grouped test reports app', () => {
     });
 
     it('only tracks the first expansion', () => {
-      mountComponent({ glFeatures: { usageDataITestingSummaryWidgetTotal: true } });
+      mountComponent();
       const expandButton = findExpandButton();
       expandButton.trigger('click');
       expandButton.trigger('click');
@@ -131,13 +128,6 @@ describe('Grouped test reports app', () => {
 
       expect(Api.trackRedisHllUserEvent).toHaveBeenCalledTimes(1);
     });
-
-    it('does not track service ping metric when disabled', () => {
-      mountComponent({ glFeatures: { usageDataITestingSummaryWidgetTotal: false } });
-      findExpandButton().trigger('click');
-
-      expect(Api.trackRedisHllUserEvent).not.toHaveBeenCalled();
-    });
   });
 
   describe('with new failed result', () => {