Commit 52aaef1b authored by Dmitry Gruzd's avatar Dmitry Gruzd

Merge branch '326058-remove-test-summary-widget-expansions-usage-data-feature-flag' into 'master'

Remove test summary widget usage ping feature flag

See merge request gitlab-org/gitlab!71781
parents 5aa98afe 5d780fc9
...@@ -3,7 +3,6 @@ import { GlButton, GlIcon } from '@gitlab/ui'; ...@@ -3,7 +3,6 @@ import { GlButton, GlIcon } from '@gitlab/ui';
import { mapActions, mapGetters, mapState } from 'vuex'; import { mapActions, mapGetters, mapState } from 'vuex';
import api from '~/api'; import api from '~/api';
import { sprintf, s__ } from '~/locale'; import { sprintf, s__ } from '~/locale';
import glFeatureFlagsMixin from '~/vue_shared/mixins/gl_feature_flags_mixin';
import GroupedIssuesList from '../components/grouped_issues_list.vue'; import GroupedIssuesList from '../components/grouped_issues_list.vue';
import { componentNames } from '../components/issue_body'; import { componentNames } from '../components/issue_body';
import ReportSection from '../components/report_section.vue'; import ReportSection from '../components/report_section.vue';
...@@ -28,7 +27,6 @@ export default { ...@@ -28,7 +27,6 @@ export default {
GlButton, GlButton,
GlIcon, GlIcon,
}, },
mixins: [glFeatureFlagsMixin()],
props: { props: {
endpoint: { endpoint: {
type: String, type: String,
...@@ -82,9 +80,7 @@ export default { ...@@ -82,9 +80,7 @@ export default {
methods: { methods: {
...mapActions(['setPaths', 'fetchReports', 'closeModal']), ...mapActions(['setPaths', 'fetchReports', 'closeModal']),
handleToggleEvent() { handleToggleEvent() {
if (this.glFeatures.usageDataITestingSummaryWidgetTotal) {
api.trackRedisHllUserEvent(this.$options.expandEvent); api.trackRedisHllUserEvent(this.$options.expandEvent);
}
}, },
reportText(report) { reportText(report) {
const { name, summary } = report || {}; const { name, summary } = report || {};
......
...@@ -37,7 +37,6 @@ class Projects::MergeRequestsController < Projects::MergeRequests::ApplicationCo ...@@ -37,7 +37,6 @@ class Projects::MergeRequestsController < Projects::MergeRequests::ApplicationCo
push_frontend_feature_flag(:core_security_mr_widget_counts, @project) push_frontend_feature_flag(:core_security_mr_widget_counts, @project)
push_frontend_feature_flag(:paginated_notes, @project, default_enabled: :yaml) push_frontend_feature_flag(:paginated_notes, @project, default_enabled: :yaml)
push_frontend_feature_flag(:confidential_notes, @project, default_enabled: :yaml) push_frontend_feature_flag(:confidential_notes, @project, default_enabled: :yaml)
push_frontend_feature_flag(:usage_data_i_testing_summary_widget_total, @project, default_enabled: :yaml)
push_frontend_feature_flag(:improved_emoji_picker, project, default_enabled: :yaml) push_frontend_feature_flag(:improved_emoji_picker, project, default_enabled: :yaml)
push_frontend_feature_flag(:diffs_virtual_scrolling, project, default_enabled: :yaml) push_frontend_feature_flag(:diffs_virtual_scrolling, project, default_enabled: :yaml)
push_frontend_feature_flag(:restructured_mr_widget, project, default_enabled: :yaml) push_frontend_feature_flag(:restructured_mr_widget, project, default_enabled: :yaml)
......
---
name: usage_data_i_testing_summary_widget_total
introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/57543
rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/326058
milestone: '13.11'
type: development
group: group::testing
default_enabled: true
...@@ -181,7 +181,6 @@ ...@@ -181,7 +181,6 @@
category: testing category: testing
redis_slot: testing redis_slot: testing
aggregation: weekly aggregation: weekly
feature_flag: usage_data_i_testing_summary_widget_total
# Project Management group # Project Management group
- name: g_project_management_issue_title_changed - name: g_project_management_issue_title_changed
category: issues_edit category: issues_edit
......
...@@ -24,7 +24,7 @@ describe('Grouped test reports app', () => { ...@@ -24,7 +24,7 @@ describe('Grouped test reports app', () => {
let wrapper; let wrapper;
let mockStore; let mockStore;
const mountComponent = ({ props = { pipelinePath }, glFeatures = {} } = {}) => { const mountComponent = ({ props = { pipelinePath } } = {}) => {
wrapper = mount(GroupedTestReportsApp, { wrapper = mount(GroupedTestReportsApp, {
store: mockStore, store: mockStore,
localVue, localVue,
...@@ -34,9 +34,6 @@ describe('Grouped test reports app', () => { ...@@ -34,9 +34,6 @@ describe('Grouped test reports app', () => {
pipelinePath, pipelinePath,
...props, ...props,
}, },
provide: {
glFeatures,
},
}); });
}; };
...@@ -114,8 +111,8 @@ describe('Grouped test reports app', () => { ...@@ -114,8 +111,8 @@ describe('Grouped test reports app', () => {
setReports(newFailedTestReports); setReports(newFailedTestReports);
}); });
it('tracks service ping metric when enabled', () => { it('tracks service ping metric', () => {
mountComponent({ glFeatures: { usageDataITestingSummaryWidgetTotal: true } }); mountComponent();
findExpandButton().trigger('click'); findExpandButton().trigger('click');
expect(Api.trackRedisHllUserEvent).toHaveBeenCalledTimes(1); expect(Api.trackRedisHllUserEvent).toHaveBeenCalledTimes(1);
...@@ -123,7 +120,7 @@ describe('Grouped test reports app', () => { ...@@ -123,7 +120,7 @@ describe('Grouped test reports app', () => {
}); });
it('only tracks the first expansion', () => { it('only tracks the first expansion', () => {
mountComponent({ glFeatures: { usageDataITestingSummaryWidgetTotal: true } }); mountComponent();
const expandButton = findExpandButton(); const expandButton = findExpandButton();
expandButton.trigger('click'); expandButton.trigger('click');
expandButton.trigger('click'); expandButton.trigger('click');
...@@ -131,13 +128,6 @@ describe('Grouped test reports app', () => { ...@@ -131,13 +128,6 @@ describe('Grouped test reports app', () => {
expect(Api.trackRedisHllUserEvent).toHaveBeenCalledTimes(1); expect(Api.trackRedisHllUserEvent).toHaveBeenCalledTimes(1);
}); });
it('does not track service ping metric when disabled', () => {
mountComponent({ glFeatures: { usageDataITestingSummaryWidgetTotal: false } });
findExpandButton().trigger('click');
expect(Api.trackRedisHllUserEvent).not.toHaveBeenCalled();
});
}); });
describe('with new failed result', () => { describe('with new failed result', () => {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment