Commit 52bc4e79 authored by Jacob Vosmaer's avatar Jacob Vosmaer

Close standard input in Gitlab::Popen.popen

parent 5dbbec46
...@@ -20,6 +20,7 @@ v 7.7.0 ...@@ -20,6 +20,7 @@ v 7.7.0
- Add alert message in case of outdated browser (IE < 10) - Add alert message in case of outdated browser (IE < 10)
- -
- Added API support for sorting projects - Added API support for sorting projects
- Close standard input in Gitlab::Popen.popen
v 7.6.0 v 7.6.0
- Fork repository to groups - Fork repository to groups
......
...@@ -21,6 +21,9 @@ module Gitlab ...@@ -21,6 +21,9 @@ module Gitlab
@cmd_output = "" @cmd_output = ""
@cmd_status = 0 @cmd_status = 0
Open3.popen3(vars, *cmd, options) do |stdin, stdout, stderr, wait_thr| Open3.popen3(vars, *cmd, options) do |stdin, stdout, stderr, wait_thr|
# We are not using stdin so we should close it, in case the command we
# are running waits for input.
stdin.close
@cmd_output << stdout.read @cmd_output << stdout.read
@cmd_output << stderr.read @cmd_output << stderr.read
@cmd_status = wait_thr.value.exitstatus @cmd_status = wait_thr.value.exitstatus
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment