Commit 52e104b2 authored by Filipa Lacerda's avatar Filipa Lacerda

Changes after review

parent 93621543
/* eslint-disable no-param-reassign */ /* eslint-disable no-param-reassign */
/* global Vue */ import Vue from 'vue';
import iconCommit from '../svg/icon_commit.svg'; import iconCommit from '../svg/icon_commit.svg';
((global) => { ((global) => {
...@@ -10,6 +10,11 @@ import iconCommit from '../svg/icon_commit.svg'; ...@@ -10,6 +10,11 @@ import iconCommit from '../svg/icon_commit.svg';
items: Array, items: Array,
stage: Object, stage: Object,
}, },
data() {
return { iconCommit };
},
template: ` template: `
<div> <div>
<div class="events-description"> <div class="events-description">
......
/* eslint-disable no-param-reassign */ /* eslint-disable no-param-reassign */
/* global Vue */ import Vue from 'vue';
import iconBranch from '../svg/icon_branch.svg'; import iconBranch from '../svg/icon_branch.svg';
((global) => { ((global) => {
...@@ -10,6 +10,9 @@ import iconBranch from '../svg/icon_branch.svg'; ...@@ -10,6 +10,9 @@ import iconBranch from '../svg/icon_branch.svg';
items: Array, items: Array,
stage: Object, stage: Object,
}, },
data() {
return { iconBranch };
},
template: ` template: `
<div> <div>
<div class="events-description"> <div class="events-description">
......
/* eslint-disable no-param-reassign */ /* eslint-disable no-param-reassign */
/* global Vue */ import Vue from 'vue';
import iconBuildStatus from '../svg/icon_build_status.svg'; import iconBuildStatus from '../svg/icon_build_status.svg';
import iconBranch from '../svg/icon_branch.svg'; import iconBranch from '../svg/icon_branch.svg';
...@@ -11,6 +11,9 @@ import iconBranch from '../svg/icon_branch.svg'; ...@@ -11,6 +11,9 @@ import iconBranch from '../svg/icon_branch.svg';
items: Array, items: Array,
stage: Object, stage: Object,
}, },
data() {
return { iconBuildStatus, iconBranch };
},
template: ` template: `
<div> <div>
<div class="events-description"> <div class="events-description">
......
...@@ -46,13 +46,17 @@ import warningSvg from 'icons/_icon_status_warning.svg'; ...@@ -46,13 +46,17 @@ import warningSvg from 'icons/_icon_status_warning.svg';
const { status } = this.pipeline.details; const { status } = this.pipeline.details;
return status.has_details ? status.details_path : false; return status.has_details ? status.details_path : false;
}, },
content() {
return `${this.svg} ${this.pipeline.details.status.text}`;
},
}, },
template: ` template: `
<td class="commit-link"> <td class="commit-link">
<a <a
:class='cssClasses' :class="cssClasses"
:href='detailsPath' :href="detailsPath"
v-html="svg + pipeline.details.status.text"> v-html="content">
</a> </a>
</td> </td>
`, `,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment