Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
530115f9
Commit
530115f9
authored
Aug 27, 2019
by
GitLab Bot
Browse files
Options
Browse Files
Download
Plain Diff
Automatic merge of gitlab-org/gitlab-ce master
parents
c83296ec
190dba6d
Changes
2
Expand all
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
99 additions
and
44 deletions
+99
-44
doc/development/database_review.md
doc/development/database_review.md
+1
-1
doc/development/migration_style_guide.md
doc/development/migration_style_guide.md
+98
-43
No files found.
doc/development/database_review.md
View file @
530115f9
...
@@ -91,7 +91,7 @@ and details for a database reviewer:
...
@@ -91,7 +91,7 @@ and details for a database reviewer:
concurrent index/foreign key helpers (with transactions disabled)
concurrent index/foreign key helpers (with transactions disabled)
-
Check consistency with
`db/schema.rb`
and that migrations are
[
reversible
](
migration_style_guide.md#reversibility
)
-
Check consistency with
`db/schema.rb`
and that migrations are
[
reversible
](
migration_style_guide.md#reversibility
)
-
Check queries timing (If any): Queries executed in a migration
-
Check queries timing (If any): Queries executed in a migration
need to fit comfortabl
e
within
`15s`
- preferably much less than that - on GitLab.com.
need to fit comfortabl
y
within
`15s`
- preferably much less than that - on GitLab.com.
-
Check
[
background migrations
](
background_migrations.md
)
:
-
Check
[
background migrations
](
background_migrations.md
)
:
-
For data migrations, establish a time estimate for execution
-
For data migrations, establish a time estimate for execution
-
They should only be used when migrating data in larger tables.
-
They should only be used when migrating data in larger tables.
...
...
doc/development/migration_style_guide.md
View file @
530115f9
This diff is collapsed.
Click to expand it.
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment