Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
53cb53f4
Commit
53cb53f4
authored
Oct 06, 2020
by
Taurie Davis
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove jquery tooltip from IDE activity bar
parent
17a184eb
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
11 additions
and
10 deletions
+11
-10
app/assets/javascripts/ide/components/activity_bar.vue
app/assets/javascripts/ide/components/activity_bar.vue
+6
-10
changelogs/unreleased/229040-activity-bar-tooltip.yml
changelogs/unreleased/229040-activity-bar-tooltip.yml
+5
-0
No files found.
app/assets/javascripts/ide/components/activity_bar.vue
View file @
53cb53f4
<
script
>
import
$
from
'
jquery
'
;
import
{
mapActions
,
mapState
}
from
'
vuex
'
;
import
{
GlIcon
}
from
'
@gitlab/ui
'
;
import
tooltip
from
'
~/vue_shared/directives/tooltip
'
;
import
{
GlIcon
,
GlTooltipDirective
}
from
'
@gitlab/ui
'
;
import
{
leftSidebarViews
}
from
'
../constants
'
;
export
default
{
...
...
@@ -10,7 +8,7 @@ export default {
GlIcon
,
},
directives
:
{
tooltip
,
GlTooltip
:
GlTooltipDirective
,
},
computed
:
{
...
mapState
([
'
currentActivityView
'
]),
...
...
@@ -22,9 +20,7 @@ export default {
this
.
updateActivityBarView
(
view
);
// TODO: We must use JQuery here to interact with the Bootstrap tooltip API
// https://gitlab.com/gitlab-org/gitlab/-/issues/217577
$
(
e
.
currentTarget
).
tooltip
(
'
hide
'
);
this
.
$root
.
$emit
(
'
bv::hide::tooltip
'
);
},
},
leftSidebarViews
,
...
...
@@ -36,7 +32,7 @@ export default {
<ul
class=
"list-unstyled"
>
<li>
<button
v-
tooltip
v-
gl-tooltip
.
right
.
viewport
:class=
"
{
active: currentActivityView === $options.leftSidebarViews.edit.name,
}"
...
...
@@ -54,7 +50,7 @@ export default {
</li>
<li>
<button
v-
tooltip
v-
gl-tooltip
.
right
.
viewport
:class=
"
{
active: currentActivityView === $options.leftSidebarViews.review.name,
}"
...
...
@@ -71,7 +67,7 @@ export default {
</li>
<li>
<button
v-
tooltip
v-
gl-tooltip
.
right
.
viewport
:class=
"
{
active: currentActivityView === $options.leftSidebarViews.commit.name,
}"
...
...
changelogs/unreleased/229040-activity-bar-tooltip.yml
0 → 100644
View file @
53cb53f4
---
title
:
Remove jquery tooltip from IDE activity bar
merge_request
:
44526
author
:
type
:
changed
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment