Commit 543dcdac authored by Douwe Maan's avatar Douwe Maan

Statisfy Robertcop and Seancop

parent 4f8c36c0
...@@ -135,15 +135,9 @@ class MergeRequestDiff < ActiveRecord::Base ...@@ -135,15 +135,9 @@ class MergeRequestDiff < ActiveRecord::Base
end end
def diff_refs=(new_diff_refs) def diff_refs=(new_diff_refs)
if new_diff_refs self.base_commit_sha = new_diff_refs&.base_sha
self.base_commit_sha = new_diff_refs.base_sha self.start_commit_sha = new_diff_refs&.start_sha
self.start_commit_sha = new_diff_refs.start_sha self.head_commit_sha = new_diff_refs&.head_sha
self.head_commit_sha = new_diff_refs.head_sha
else
self.base_commit_sha = nil
self.start_commit_sha = nil
self.head_commit_sha = nil
end
end end
def diff_refs def diff_refs
......
...@@ -81,7 +81,7 @@ ...@@ -81,7 +81,7 @@
- if @start_sha - if @start_sha
Comments are disabled because you're comparing two versions of this merge request. Comments are disabled because you're comparing two versions of this merge request.
- else - else
Discussions on this old version of the merge request are displayed but comment creation is disabled. Discussions on this version of the merge request are displayed but comment creation is disabled.
.pull-right .pull-right
= link_to 'Show latest version', diffs_namespace_project_merge_request_path(@project.namespace, @project, @merge_request), class: 'btn btn-sm' = link_to 'Show latest version', diffs_namespace_project_merge_request_path(@project.namespace, @project, @merge_request), class: 'btn btn-sm'
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment