Commit 5497fa47 authored by Dan Davison's avatar Dan Davison

Merge branch 'qa-fix-issue-boards-specs' into 'master'

Update and unquarantine issue board tests

See merge request gitlab-org/gitlab!44055
parents e7e610f8 e9383c1f
...@@ -10,7 +10,7 @@ module QA ...@@ -10,7 +10,7 @@ module QA
attribute :label do attribute :label do
QA::Resource::Label.fabricate_via_api! do |label| QA::Resource::Label.fabricate_via_api! do |label|
label.project = board.project label.project = board.project
label.title = 'Doing' label.title = 'Testing'
end end
end end
......
# frozen_string_literal: true # frozen_string_literal: true
module QA module QA
RSpec.describe 'Plan', quarantine: { issue: 'https://gitlab.com/gitlab-org/gitlab/-/issues/259054', type: :stale } do RSpec.describe 'Plan' do
describe 'Configurable issue board' do describe 'Configurable issue board' do
let(:label_board_list) do let(:label_board_list) do
EE::Resource::Board::BoardList::Project::LabelBoardList.fabricate_via_api! EE::Resource::Board::BoardList::Project::LabelBoardList.fabricate_via_api!
......
# frozen_string_literal: true # frozen_string_literal: true
module QA module QA
RSpec.describe 'Plan', quarantine: { issue: 'https://gitlab.com/gitlab-org/gitlab/-/issues/259054', type: :stale } do RSpec.describe 'Plan' do
describe 'Configure issue board by label' do describe 'Configure issue board by label' do
let(:label_board_list) do let(:label_board_list) do
EE::Resource::Board::BoardList::Project::LabelBoardList.fabricate_via_api! EE::Resource::Board::BoardList::Project::LabelBoardList.fabricate_via_api!
end end
let(:doing) { 'Doing' } let(:testing) { 'Testing' }
let(:ready_for_dev) { 'Ready for development' } let(:ready_for_dev) { 'Ready for development' }
let(:issue_1) { 'Issue 1' } let(:issue_1) { 'Issue 1' }
...@@ -16,7 +16,7 @@ module QA ...@@ -16,7 +16,7 @@ module QA
before do before do
Flow::Login.sign_in Flow::Login.sign_in
fabricate_issue_with_label(label_board_list.project, issue_1, doing) fabricate_issue_with_label(label_board_list.project, issue_1, testing)
fabricate_issue_with_label(label_board_list.project, issue_2, ready_for_dev) fabricate_issue_with_label(label_board_list.project, issue_2, ready_for_dev)
label_board_list.project.visit! label_board_list.project.visit!
...@@ -25,7 +25,7 @@ module QA ...@@ -25,7 +25,7 @@ module QA
it 'shows only issues that match the configured label', testcase: 'https://gitlab.com/gitlab-org/quality/testcases/-/issues/646' do it 'shows only issues that match the configured label', testcase: 'https://gitlab.com/gitlab-org/quality/testcases/-/issues/646' do
Page::Component::IssueBoard::Show.perform do |show| Page::Component::IssueBoard::Show.perform do |show|
show.configure_by_label(doing) show.configure_by_label(testing)
expect(show).not_to have_content(issue_2) expect(show).not_to have_content(issue_2)
expect(show.boards_list_cards_area_with_index(1)).to have_content(issue_1) expect(show.boards_list_cards_area_with_index(1)).to have_content(issue_1)
......
...@@ -9,8 +9,8 @@ module QA ...@@ -9,8 +9,8 @@ module QA
let(:issue_title) { 'Issue to test board list' } let(:issue_title) { 'Issue to test board list' }
context 'Label issue board', quarantine: { issue: 'https://gitlab.com/gitlab-org/gitlab/-/issues/259054', type: :stale } do context 'Label issue board' do
let(:label) { 'Doing' } let(:label) { 'Testing' }
let(:label_board_list) do let(:label_board_list) do
EE::Resource::Board::BoardList::Project::LabelBoardList.fabricate_via_api! EE::Resource::Board::BoardList::Project::LabelBoardList.fabricate_via_api!
...@@ -26,7 +26,7 @@ module QA ...@@ -26,7 +26,7 @@ module QA
go_to_project_board(label_board_list.project) go_to_project_board(label_board_list.project)
end end
it 'shows the just created board with a "Doing" (label) list, and an issue on it', testcase: 'https://gitlab.com/gitlab-org/quality/testcases/-/issues/606' do it 'shows the just created board with a "Testing" (label) list, and an issue on it', testcase: 'https://gitlab.com/gitlab-org/quality/testcases/-/issues/606' do
Page::Component::IssueBoard::Show.perform do |show| Page::Component::IssueBoard::Show.perform do |show|
expect(show.boards_dropdown).to have_content(label_board_list.board.name) expect(show.boards_dropdown).to have_content(label_board_list.board.name)
expect(show.boards_list_header_with_index(1)).to have_content(label) expect(show.boards_list_header_with_index(1)).to have_content(label)
......
# frozen_string_literal: true # frozen_string_literal: true
module QA module QA
RSpec.describe 'Plan', quarantine: { issue: 'https://gitlab.com/gitlab-org/gitlab/-/issues/259054', type: :stale } do RSpec.describe 'Plan' do
describe 'Read-only board configuration' do describe 'Read-only board configuration' do
let(:qa_user) do let(:qa_user) do
Resource::User.fabricate_or_use(Runtime::Env.gitlab_qa_username_1, Runtime::Env.gitlab_qa_password_1) Resource::User.fabricate_or_use(Runtime::Env.gitlab_qa_username_1, Runtime::Env.gitlab_qa_password_1)
......
# frozen_string_literal: true # frozen_string_literal: true
module QA module QA
RSpec.describe 'Plan', quarantine: { issue: 'https://gitlab.com/gitlab-org/gitlab/-/issues/259054', type: :stale } do RSpec.describe 'Plan' do
describe 'Sum of issues weights on issue board' do describe 'Sum of issues weights on issue board' do
let(:label_board_list) do let(:label_board_list) do
EE::Resource::Board::BoardList::Project::LabelBoardList.fabricate_via_api! EE::Resource::Board::BoardList::Project::LabelBoardList.fabricate_via_api!
end end
let(:label) { 'Doing' } let(:label) { 'Testing' }
let(:weight_for_issue_1) { 5 } let(:weight_for_issue_1) { 5 }
let(:weight_for_issue_2) { 3 } let(:weight_for_issue_2) { 3 }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment