Commit 54a35028 authored by Illya Klymov's avatar Illya Klymov

Downgrade D3 to 4.13

parent fd74d775
...@@ -124,7 +124,9 @@ export default { ...@@ -124,7 +124,9 @@ export default {
}, },
}, },
mounted() { mounted() {
this.draw(); if (!this.allValuesEmpty) {
this.draw();
}
}, },
methods: { methods: {
draw() { draw() {
...@@ -151,14 +153,7 @@ export default { ...@@ -151,14 +153,7 @@ export default {
this.yScale = d3.scaleLinear().rangeRound([this.vbHeight, 0]); this.yScale = d3.scaleLinear().rangeRound([this.vbHeight, 0]);
this.xScale.domain(this.graphData.map(d => d.name)); this.xScale.domain(this.graphData.map(d => d.name));
/* this.yScale.domain([0, d3.max(this.graphData.map(d => d.value))]);
If we have all-zero graph we want graph to center 0 on axis and not to draw
any kind of ticks on Y axis. Infinity allows us to do that.
See https://gitlab.com/gitlab-org/gitlab/merge_requests/20627#note_251484582
for detailed explanation
*/
this.yScale.domain([0, d3.max(this.graphData.map(d => d.value)) || Infinity]);
// Zoom/Panning Function // Zoom/Panning Function
this.zoom = d3 this.zoom = d3
......
...@@ -66,7 +66,7 @@ ...@@ -66,7 +66,7 @@
"core-js": "^3.2.1", "core-js": "^3.2.1",
"cropper": "^2.3.0", "cropper": "^2.3.0",
"css-loader": "^1.0.0", "css-loader": "^1.0.0",
"d3": "^5.12.0", "d3": "^4.13.0",
"d3-scale": "^1.0.7", "d3-scale": "^1.0.7",
"d3-selection": "^1.2.0", "d3-selection": "^1.2.0",
"dateformat": "^3.0.3", "dateformat": "^3.0.3",
......
This diff is collapsed.
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment