Merge branch '49011-board-user-finder-fix' into 'master'

Fix Boards::UsersFinder usage inside EE namespace

Closes #6865

See merge request gitlab-org/gitlab-ee!6438

ee/app/services/ee/boards/lists/create_service.rb

@@ -24,12 +24,12 @@ module EE
         end
 
         def find_user(board)
-          user_ids = user_finder(board).select(:user_id)
-          ::User.where(id: user_ids).find(params[:assignee_id])
+          user_ids = user_finder(board).execute.select(:user_id)
+          ::User.where(id: user_ids).find(params['assignee_id'])
         end
 
         def user_finder(board)
-          @user_finder ||= Boards::UsersFinder.new(board, current_user)
+          @user_finder ||= ::Boards::UsersFinder.new(board, current_user)
         end
       end
     end

ee/spec/services/ee/boards/lists/create_service_spec.rb

+require 'spec_helper'
+
+describe Boards::Lists::CreateService do
+  describe '#execute' do
+    let(:parent) { create(:project) }
+    let(:board) { create(:board, project: parent) }
+    let(:label) { create(:label, project: parent, name: 'in-progress') }
+
+    let(:user) { create(:user) }
+    let(:other_user) { create(:user) }
+
+    subject(:service) { described_class.new(parent, user, 'assignee_id' => other_user.id) }
+
+    before do
+      parent.add_developer(user)
+      parent.add_developer(other_user)
+
+      stub_licensed_features(board_assignee_lists: true)
+    end
+
+    it 'creates a new assignee list' do
+      list = service.execute(board)
+
+      expect(list.list_type).to eq('assignee')
+      expect(list).to be_valid
+    end
+  end
+end