Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
5684220b
Commit
5684220b
authored
Nov 04, 2020
by
peterhegman
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Add loading icon to group members view
Shows loading icon while view is rendering to improve UX
parent
573a263c
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
8 additions
and
0 deletions
+8
-0
app/views/groups/group_members/index.html.haml
app/views/groups/group_members/index.html.haml
+8
-0
No files found.
app/views/groups/group_members/index.html.haml
View file @
5684220b
...
...
@@ -70,6 +70,8 @@
=
render
'shared/members/sort_dropdown'
-
if
vue_members_list_enabled
.js-group-members-list
{
data:
group_members_list_data_attributes
(
@group
,
@members
)
}
.loading
.spinner.spinner-md
-
else
%ul
.content-list.members-list
{
data:
{
qa_selector:
'members_list'
}
}
=
render
partial:
'shared/members/member'
,
...
...
@@ -86,6 +88,8 @@
=
html_escape
(
_
(
'Groups with access to %{strong_start}%{group_name}%{strong_end}'
))
%
{
group_name:
@group
.
name
,
strong_start:
'<strong>'
.
html_safe
,
strong_end:
'</strong>'
.
html_safe
}
-
if
vue_members_list_enabled
.js-group-linked-list
{
data:
linked_groups_list_data_attributes
(
@group
)
}
.loading
.spinner.spinner-md
-
else
%ul
.content-list.members-list
{
data:
{
qa_selector:
'groups_list'
}
}
-
@group
.
shared_with_group_links
.
each
do
|
group_link
|
...
...
@@ -100,6 +104,8 @@
=
render
'shared/members/search_field'
,
name:
'search_invited'
-
if
vue_members_list_enabled
.js-group-invited-members-list
{
data:
group_members_list_data_attributes
(
@group
,
@invited_members
)
}
.loading
.spinner.spinner-md
-
else
%ul
.content-list.members-list
=
render
partial:
'shared/members/member'
,
...
...
@@ -116,6 +122,8 @@
=
html_escape
(
_
(
'Users requesting access to %{strong_start}%{group_name}%{strong_end}'
))
%
{
group_name:
@group
.
name
,
strong_start:
'<strong>'
.
html_safe
,
strong_end:
'</strong>'
.
html_safe
}
-
if
vue_members_list_enabled
.js-group-access-requests-list
{
data:
group_members_list_data_attributes
(
@group
,
@requesters
)
}
.loading
.spinner.spinner-md
-
else
%ul
.content-list.members-list
=
render
partial:
'shared/members/member'
,
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment