Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
576098ec
Commit
576098ec
authored
Nov 06, 2020
by
Marvin Karegyeya
Committed by
Andrew Fontaine
Nov 06, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
GlDeprecatedDropdown to GlDropdown in cli_commands.vue
parent
7c4f0c96
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
13 additions
and
9 deletions
+13
-9
app/assets/javascripts/registry/explorer/components/list_page/cli_commands.vue
...s/registry/explorer/components/list_page/cli_commands.vue
+6
-7
changelogs/unreleased/Replace-GlDeprecatedDropdown-with-GlDropdown-in-app-assets-javascripts-re.yml
...Dropdown-with-GlDropdown-in-app-assets-javascripts-re.yml
+5
-0
spec/frontend/registry/explorer/components/list_page/cli_commands_spec.js
...gistry/explorer/components/list_page/cli_commands_spec.js
+2
-2
No files found.
app/assets/javascripts/registry/explorer/components/list_page/cli_commands.vue
View file @
576098ec
<
script
>
import
{
GlD
eprecatedD
ropdown
}
from
'
@gitlab/ui
'
;
import
{
GlDropdown
}
from
'
@gitlab/ui
'
;
import
{
mapGetters
}
from
'
vuex
'
;
import
Tracking
from
'
~/tracking
'
;
import
CodeInstruction
from
'
~/vue_shared/components/registry/code_instruction.vue
'
;
...
...
@@ -17,7 +17,7 @@ const trackingLabel = 'quickstart_dropdown';
export
default
{
components
:
{
GlD
eprecatedD
ropdown
,
GlDropdown
,
CodeInstruction
,
},
mixins
:
[
Tracking
.
mixin
({
label
:
trackingLabel
})],
...
...
@@ -37,15 +37,14 @@ export default {
};
</
script
>
<
template
>
<gl-d
eprecated-d
ropdown
<gl-dropdown
:text=
"$options.i18n.QUICK_START"
variant=
"primary"
size=
"sm"
variant=
"info"
right
@
shown=
"track('click_dropdown')"
>
<!-- This li is used as a container since gl-dropdown produces a root ul, this mimics the functionality exposed by b-dropdown-form -->
<li
role=
"presentation"
class=
"px-2 py-1
dropdown-menu-large
"
>
<li
role=
"presentation"
class=
"px-2 py-1"
>
<code-instruction
:label=
"$options.i18n.LOGIN_COMMAND_LABEL"
:instruction=
"dockerLoginCommand"
...
...
@@ -71,5 +70,5 @@ export default {
:tracking-label=
"$options.trackingLabel"
/>
</li>
</gl-d
eprecated-d
ropdown>
</gl-dropdown>
</
template
>
changelogs/unreleased/Replace-GlDeprecatedDropdown-with-GlDropdown-in-app-assets-javascripts-re.yml
0 → 100644
View file @
576098ec
---
title
:
Replace Deprecated Dropdown in Container Registry Explorer Page
merge_request
:
41425
author
:
nuwe1
type
:
other
spec/frontend/registry/explorer/components/list_page/cli_commands_spec.js
View file @
576098ec
import
Vuex
from
'
vuex
'
;
import
{
mount
,
createLocalVue
}
from
'
@vue/test-utils
'
;
import
{
GlD
eprecatedD
ropdown
}
from
'
@gitlab/ui
'
;
import
{
GlDropdown
}
from
'
@gitlab/ui
'
;
import
Tracking
from
'
~/tracking
'
;
import
*
as
getters
from
'
~/registry/explorer/stores/getters
'
;
import
QuickstartDropdown
from
'
~/registry/explorer/components/list_page/cli_commands.vue
'
;
...
...
@@ -23,7 +23,7 @@ describe('cli_commands', () => {
let
wrapper
;
let
store
;
const
findDropdownButton
=
()
=>
wrapper
.
find
(
GlD
eprecatedD
ropdown
);
const
findDropdownButton
=
()
=>
wrapper
.
find
(
GlDropdown
);
const
findCodeInstruction
=
()
=>
wrapper
.
findAll
(
CodeInstruction
);
const
mountComponent
=
()
=>
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment