Refactor method to avoid disabling linters

Unify Gitlab::Access calls

app/helpers/namespaces_helper.rb

@@ -49,14 +49,12 @@ module NamespacesHelper
     end
   end
 
-  # rubocop: disable CodeReuse/ActiveRecord
   def namespaces_options_with_developer_maintainer_access(options = {})
     selected = options.delete(:selected) || :current_user
     options[:groups] = current_user.manageable_groups_with_routes(include_groups_with_developer_maintainer_access: true)
 
     namespaces_options(selected, options)
   end
-  # rubocop: enable CodeReuse/ActiveRecord
 
   private
 

app/views/groups/settings/_project_creation_level.html.haml

 .form-group
   = f.label s_('ProjectCreationLevel|Allowed to create projects'), class: 'label-bold'
-  = f.select :project_creation_level, options_for_select(Gitlab::Access.project_creation_options, group.project_creation_level), {}, class: 'form-control'
+  = f.select :project_creation_level, options_for_select(::Gitlab::Access.project_creation_options, group.project_creation_level), {}, class: 'form-control'

db/migrate/20190311132527_add_project_creation_level_to_namespaces.rb

@@ -8,15 +8,9 @@ class AddProjectCreationLevelToNamespaces < ActiveRecord::Migration[5.0]
 
   DOWNTIME = false
 
-  def up
+  def change
     unless column_exists?(:namespaces, :project_creation_level)
-      add_column(:namespaces, :project_creation_level, :integer)
-    end
-  end
-
-  def down
-    if column_exists?(:namespaces, :project_creation_level)
-      remove_column(:namespaces, :project_creation_level, :integer)
+      add_column :namespaces, :project_creation_level, :integer
     end
   end
 end

lib/api/settings.rb

@@ -40,8 +40,8 @@ module API
       end
       optional :container_registry_token_expire_delay, type: Integer, desc: 'Authorization token duration (minutes)'
       optional :default_artifacts_expire_in, type: String, desc: "Set the default expiration time for each job's artifacts"
-      optional :default_project_creation, type: Integer, values: Gitlab::Access.project_creation_values, desc: 'Determine if developers can create projects in the group'
-      optional :default_branch_protection, type: Integer, values: Gitlab::Access.protection_values, desc: 'Determine if developers can push to master'
+      optional :default_project_creation, type: Integer, values: ::Gitlab::Access.project_creation_values, desc: 'Determine if developers can create projects in the group'
+      optional :default_branch_protection, type: Integer, values: ::Gitlab::Access.protection_values, desc: 'Determine if developers can push to master'
       optional :default_group_visibility, type: String, values: Gitlab::VisibilityLevel.string_values, desc: 'The default group visibility'
       optional :default_project_visibility, type: String, values: Gitlab::VisibilityLevel.string_values, desc: 'The default project visibility'
       optional :default_projects_limit, type: Integer, desc: 'The maximum number of personal projects'

spec/requests/api/settings_spec.rb

@@ -66,13 +66,13 @@ describe API::Settings, 'Settings' do
             performance_bar_allowed_group_path: group.full_path,
             instance_statistics_visibility_private: true,
             diff_max_patch_bytes: 150_000,
-            default_branch_protection: Gitlab::Access::PROTECTION_DEV_CAN_MERGE,
+            default_branch_protection: ::Gitlab::Access::PROTECTION_DEV_CAN_MERGE,
             local_markdown_version: 3
           }
 
         expect(response).to have_gitlab_http_status(200)
         expect(json_response['default_projects_limit']).to eq(3)
-        expect(json_response['default_project_creation']).to eq(Gitlab::Access::DEVELOPER_MAINTAINER_PROJECT_ACCESS)
+        expect(json_response['default_project_creation']).to eq(::Gitlab::Access::DEVELOPER_MAINTAINER_PROJECT_ACCESS)
         expect(json_response['password_authentication_enabled_for_web']).to be_falsey
         expect(json_response['repository_storages']).to eq(['custom'])
         expect(json_response['plantuml_enabled']).to be_truthy