Merge branch 'deprecated-positional-seperator-parameter' into 'master'

Passing the separator argument as a positional parameter is deprecated

See merge request gitlab-org/gitlab-ce!23334

changelogs/unreleased/deprecated-positional-seperator-parameter.yml

+---
+title: Passing the separator argument as a positional parameter is deprecated
+merge_request: 23334
+author: Jasper Maes
+type: other

spec/support/services/migrate_to_ghost_user_service_shared_examples.rb

@@ -86,7 +86,7 @@ shared_examples "migrating a deleted user's associated records to the ghost user
       end
 
       it "blocks the user before #{record_class_name} migration begins" do
-        expect(service).to receive("migrate_#{record_class_name.parameterize('_').pluralize}".to_sym) do
+        expect(service).to receive("migrate_#{record_class_name.parameterize(separator: '_').pluralize}".to_sym) do
           expect(user.reload).to be_blocked
         end