Merge branch 'danger_commit_message_errors' into 'master'

Fix Danger commit message errors

See merge request gitlab-org/gitlab-ce!24337

danger/commit_messages/Dangerfile

@@ -2,6 +2,9 @@
 
 require 'json'
 
+URL_LIMIT_SUBJECT = "https://chris.beams.io/posts/git-commit/#limit-50"
+URL_GIT_COMMIT = "https://chris.beams.io/posts/git-commit/"
+
 # rubocop: disable Style/SignalException
 # rubocop: disable Metrics/CyclomaticComplexity
 # rubocop: disable Metrics/PerceivedComplexity
@@ -14,9 +17,6 @@ class EmojiChecker
   DIGESTS = File.expand_path('../../fixtures/emojis/digests.json', __dir__)
   ALIASES = File.expand_path('../../fixtures/emojis/aliases.json', __dir__)
 
-  URL_LIMIT_SUBJECT = "https://chris.beams.io/posts/git-commit/#limit-50"
-  URL_GIT_COMMIT = "https://chris.beams.io/posts/git-commit/"
-
   # A regex that indicates a piece of text _might_ include an Emoji. The regex
   # alone is not enough, as we'd match `:foo:bar:baz`. Instead, we use this
   # regex to save us from having to check for all possible emoji names when we