Merge branch 'rm-underscore-from-commons' into 'master'

Remove Last Ref of Underscore

See merge request gitlab-org/gitlab!29998

app/assets/javascripts/commons/index.js

-import 'underscore';
 import './polyfills';
 import './jquery';
 import './bootstrap';

config/webpack.vendor.config.js

@@ -29,7 +29,6 @@ module.exports = {
       'core-js',
       'echarts',
       'lodash',
-      'underscore',
       'vuex',
       'pikaday',
       'vue/dist/vue.esm.js',

package.json

@@ -124,7 +124,6 @@
     "tiptap-commands": "^1.4.0",
     "tiptap-extensions": "^1.8.0",
     "tributejs": "4.1.3",
-    "underscore": "^1.9.2",
     "unfetch": "^4.1.0",
     "url-loader": "^3.0.0",
     "visibilityjs": "^1.2.4",

yarn.lock

@@ -11376,11 +11376,6 @@ underscore@1.6.0, underscore@~1.6.0:
   resolved "https://registry.yarnpkg.com/underscore/-/underscore-1.6.0.tgz#8b38b10cacdef63337b8b24e4ff86d45aea529a8"
   integrity sha1-izixDKze9jM3uLJOT/htRa6lKag=
 
-underscore@^1.9.2:
-  version "1.9.2"
-  resolved "https://registry.yarnpkg.com/underscore/-/underscore-1.9.2.tgz#0c8d6f536d6f378a5af264a72f7bec50feb7cf2f"
-  integrity sha512-D39qtimx0c1fI3ya1Lnhk3E9nONswSKhnffBI0gME9C99fYOkNi04xs8K6pePLhvl1frbDemkaBQ5ikWllR2HQ==
-
 underscore@~1.8.3:
   version "1.8.3"
   resolved "https://registry.yarnpkg.com/underscore/-/underscore-1.8.3.tgz#4f3fb53b106e6097fcf9cb4109f2a5e9bdfa5022"