Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
5c3316c2
Commit
5c3316c2
authored
Mar 18, 2018
by
blackst0ne
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
[Rails5] Update active_record_locking initializer
parent
5ae91f32
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
56 additions
and
52 deletions
+56
-52
config/initializers/active_record_locking.rb
config/initializers/active_record_locking.rb
+56
-52
No files found.
config/initializers/active_record_locking.rb
View file @
5c3316c2
# rubocop:disable Lint/RescueException
# This patch fixes https://github.com/rails/rails/issues/26024
# TODO: Remove it when it's no longer necessary
module
ActiveRecord
module
Locking
module
Optimistic
# We overwrite this method because we don't want to have default value
# for newly created records
def
_create_record
(
attribute_names
=
self
.
attribute_names
,
*
)
# :nodoc:
super
end
# Remove this entire initializer when we are at rails 5.0.
# This file fixes the bug (see below) which has been fixed in the upstream.
unless
Gitlab
.
rails5?
# This patch fixes https://github.com/rails/rails/issues/26024
# TODO: Remove it when it's no longer necessary
module
ActiveRecord
module
Locking
module
Optimistic
# We overwrite this method because we don't want to have default value
# for newly created records
def
_create_record
(
attribute_names
=
self
.
attribute_names
,
*
)
# :nodoc:
super
end
def
_update_record
(
attribute_names
=
self
.
attribute_names
)
#:nodoc:
return
super
unless
locking_enabled?
return
0
if
attribute_names
.
empty?
def
_update_record
(
attribute_names
=
self
.
attribute_names
)
#:nodoc:
return
super
unless
locking_enabled?
return
0
if
attribute_names
.
empty?
lock_col
=
self
.
class
.
locking_column
lock_col
=
self
.
class
.
locking_column
previous_lock_value
=
send
(
lock_col
).
to_i
# rubocop:disable GitlabSecurity/PublicSend
previous_lock_value
=
send
(
lock_col
).
to_i
# rubocop:disable GitlabSecurity/PublicSend
# This line is added as a patch
previous_lock_value
=
nil
if
previous_lock_value
==
'0'
||
previous_lock_value
==
0
# This line is added as a patch
previous_lock_value
=
nil
if
previous_lock_value
==
'0'
||
previous_lock_value
==
0
increment_lock
increment_lock
attribute_names
+=
[
lock_col
]
attribute_names
.
uniq!
attribute_names
+=
[
lock_col
]
attribute_names
.
uniq!
begin
relation
=
self
.
class
.
unscoped
begin
relation
=
self
.
class
.
unscoped
affected_rows
=
relation
.
where
(
self
.
class
.
primary_key
=>
id
,
lock_col
=>
previous_lock_value
).
update_all
(
attributes_for_update
(
attribute_names
).
map
do
|
name
|
[
name
,
_read_attribute
(
name
)]
end
.
to_h
)
affected_rows
=
relation
.
where
(
self
.
class
.
primary_key
=>
id
,
lock_col
=>
previous_lock_value
).
update_all
(
attributes_for_update
(
attribute_names
).
map
do
|
name
|
[
name
,
_read_attribute
(
name
)]
end
.
to_h
)
unless
affected_rows
==
1
raise
ActiveRecord
::
StaleObjectError
.
new
(
self
,
"update"
)
end
unless
affected_rows
==
1
raise
ActiveRecord
::
StaleObjectError
.
new
(
self
,
"update"
)
end
affected_rows
affected_rows
# If something went wrong, revert the version.
rescue
Exception
send
(
lock_col
+
'='
,
previous_lock_value
)
# rubocop:disable GitlabSecurity/PublicSend
raise
# If something went wrong, revert the version.
rescue
Exception
send
(
lock_col
+
'='
,
previous_lock_value
)
# rubocop:disable GitlabSecurity/PublicSend
raise
end
end
end
# This is patched because we need it to query `lock_version IS NULL`
# rather than `lock_version = 0` whenever lock_version is NULL.
def
relation_for_destroy
return
super
unless
locking_enabled?
# This is patched because we need it to query `lock_version IS NULL`
# rather than `lock_version = 0` whenever lock_version is NULL.
def
relation_for_destroy
return
super
unless
locking_enabled?
column_name
=
self
.
class
.
locking_column
super
.
where
(
self
.
class
.
arel_table
[
column_name
].
eq
(
self
[
column_name
]))
column_name
=
self
.
class
.
locking_column
super
.
where
(
self
.
class
.
arel_table
[
column_name
].
eq
(
self
[
column_name
]))
end
end
end
# This is patched because we want `lock_version` default to `NULL`
# rather than `0`
class
LockingType
<
SimpleDelegator
def
type_cast_from_database
(
value
)
super
# This is patched because we want `lock_version` default to `NULL`
# rather than `0`
class
LockingType
<
SimpleDelegator
def
type_cast_from_database
(
value
)
super
end
end
end
end
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment