Merge branch 'rails-save-bang-28' into 'master'

Fix Rails/SaveBang offenses for spec/requests/api/*

See merge request gitlab-org/gitlab!41362

.rubocop_todo.yml

@@ -1165,9 +1165,6 @@ Rails/SaveBang:
     - 'spec/presenters/ci/build_runner_presenter_spec.rb'
     - 'spec/presenters/ci/trigger_presenter_spec.rb'
     - 'spec/presenters/packages/conan/package_presenter_spec.rb'
-    - 'spec/requests/api/access_requests_spec.rb'
-    - 'spec/requests/api/boards_spec.rb'
-    - 'spec/requests/api/branches_spec.rb'
     - 'spec/requests/api/ci/runner_spec.rb'
     - 'spec/requests/api/commit_statuses_spec.rb'
     - 'spec/requests/api/conan_packages_spec.rb'

changelogs/unreleased/rails-save-bang-28.yml

+---
+title: Fix Rails/SaveBang offenses for spec/requests/api/*
+merge_request: 41362
+author: Rajendra Kadam
+type: fixed

spec/requests/api/access_requests_spec.rb

@@ -90,7 +90,7 @@ RSpec.describe API::AccessRequests do
       context 'when authenticated as a stranger' do
         context "when access request is disabled for the #{source_type}" do
           before do
-            source.update(request_access_enabled: false)
+            source.update!(request_access_enabled: false)
           end
 
           it 'returns 403' do

spec/requests/api/boards_spec.rb

@@ -41,7 +41,7 @@ RSpec.describe API::Boards do
     it 'creates a new issue board list for group labels' do
       group = create(:group)
       group_label = create(:group_label, group: group)
-      board_parent.update(group: group)
+      board_parent.update!(group: group)
 
       post api(url, user), params: { label_id: group_label.id }
 
@@ -54,7 +54,7 @@ RSpec.describe API::Boards do
       group = create(:group)
       sub_group = create(:group, parent: group)
       group_label = create(:group_label, group: group)
-      board_parent.update(group: sub_group)
+      board_parent.update!(group: sub_group)
       group.add_developer(user)
       sub_group.add_developer(user)
 

spec/requests/api/branches_spec.rb

@@ -181,7 +181,7 @@ RSpec.describe API::Branches do
 
     context 'when unauthenticated', 'and project is public' do
       before do
-        project.update(visibility_level: Gitlab::VisibilityLevel::PUBLIC)
+        project.update!(visibility_level: Gitlab::VisibilityLevel::PUBLIC)
       end
 
       it_behaves_like 'repository branches'
@@ -289,7 +289,7 @@ RSpec.describe API::Branches do
 
     context 'when unauthenticated', 'and project is public' do
       before do
-        project.update(visibility_level: Gitlab::VisibilityLevel::PUBLIC)
+        project.update!(visibility_level: Gitlab::VisibilityLevel::PUBLIC)
       end
 
       it_behaves_like 'repository branch'