Merge branch 'sh-disable-pager-on-small-counts' into 'master'

Fix erroneous "No activities found" message

Closes #27118

See merge request gitlab-org/gitlab!18434

app/assets/javascripts/pager.js

@@ -56,6 +56,10 @@ export default {
     $('.content_list').append(html);
     if (count > 0) {
       this.offset += count;
+
+      if (count < this.limit) {
+        this.disable = true;
+      }
     } else {
       this.disable = true;
     }

changelogs/unreleased/sh-disable-pager-on-small-counts.yml

+---
+title: Fix erroneous "No activities found" message
+merge_request: 18434
+author:
+type: fixed

spec/javascripts/pager_spec.js

@@ -63,9 +63,9 @@ describe('pager', () => {
   describe('getOld', () => {
     const urlRegex = /(.*)some_list(.*)$/;
 
-    function mockSuccess() {
+    function mockSuccess(count = 0) {
       axiosMock.onGet(urlRegex).reply(200, {
-        count: 0,
+        count,
         html: '',
       });
     }
@@ -142,5 +142,21 @@ describe('pager', () => {
         done();
       });
     });
+
+    it('disables if return count is less than limit', done => {
+      Pager.offset = 0;
+      Pager.limit = 20;
+
+      mockSuccess(1);
+      spyOn(Pager.loading, 'hide');
+      Pager.getOld();
+
+      setTimeout(() => {
+        expect(Pager.loading.hide).toHaveBeenCalled();
+        expect(Pager.disable).toBe(true);
+
+        done();
+      });
+    });
   });
 });