Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
5c8b211c
Commit
5c8b211c
authored
Jul 06, 2016
by
Drew Blessing
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Revert "Merge branch 'fix_stale_last_owner' into 'master'"
This reverts merge request !529
parent
9b9a31c7
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
0 additions
and
8 deletions
+0
-8
CHANGELOG-EE
CHANGELOG-EE
+0
-3
lib/gitlab/ldap/group_sync.rb
lib/gitlab/ldap/group_sync.rb
+0
-5
No files found.
CHANGELOG-EE
View file @
5c8b211c
...
...
@@ -3,9 +3,6 @@ Please view this file on the master branch, on stable branches it's out of date.
v 8.10.0 (unreleased)
- Rename Git Hooks to Push Rules
v 8.9.5
- Prevent stale data in LDAP group sync last owner check.
v 8.9.4
- Improve how File Lock feature works with nested items. !497
...
...
lib/gitlab/ldap/group_sync.rb
View file @
5c8b211c
...
...
@@ -304,11 +304,6 @@ module Gitlab
next
end
# Since we're removing users in this loop, `group.reload`
# before checking `last_owner?` to prevent stale owner information.
# Without a reload, this check would return a false negative.
group
.
reload
# Check and update the access level. If `desired_access` is `nil`
# we need to delete the user from the group.
if
desired_access
.
present?
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment