Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
5c9e4888
Commit
5c9e4888
authored
Sep 28, 2020
by
Kamil Trzciński
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove `ci_pipeline_rewind_iid` feature flag
It is no longer needed.
parent
3fd9cc8a
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
5 additions
and
32 deletions
+5
-32
app/services/ci/create_pipeline_service.rb
app/services/ci/create_pipeline_service.rb
+1
-2
config/feature_flags/development/ci_pipeline_rewind_iid.yml
config/feature_flags/development/ci_pipeline_rewind_iid.yml
+0
-7
spec/services/ci/create_pipeline_service_spec.rb
spec/services/ci/create_pipeline_service_spec.rb
+4
-23
No files found.
app/services/ci/create_pipeline_service.rb
View file @
5c9e4888
...
...
@@ -82,8 +82,7 @@ module Ci
schedule_head_pipeline_update
if
pipeline
.
persisted?
# If pipeline is not persisted, try to recover IID
pipeline
.
reset_project_iid
unless
pipeline
.
persisted?
||
Feature
.
disabled?
(
:ci_pipeline_rewind_iid
,
project
,
default_enabled:
true
)
pipeline
.
reset_project_iid
unless
pipeline
.
persisted?
pipeline
end
...
...
config/feature_flags/development/ci_pipeline_rewind_iid.yml
deleted
100644 → 0
View file @
3fd9cc8a
---
name
:
ci_pipeline_rewind_iid
introduced_by_url
:
rollout_issue_url
:
group
:
type
:
development
default_enabled
:
true
spec/services/ci/create_pipeline_service_spec.rb
View file @
5c9e4888
...
...
@@ -731,30 +731,11 @@ RSpec.describe Ci::CreatePipelineService do
.
and_call_original
end
context
'when ci_pipeline_rewind_iid is enabled'
do
before
do
stub_feature_flags
(
ci_pipeline_rewind_iid:
true
)
end
it
'rewinds iid'
do
result
=
execute_service
expect
(
result
).
not_to
be_persisted
expect
(
internal_id
.
last_value
).
to
eq
(
0
)
end
end
context
'when ci_pipeline_rewind_iid is disabled'
do
before
do
stub_feature_flags
(
ci_pipeline_rewind_iid:
false
)
end
it
'does not rewind iid'
do
result
=
execute_service
it
'rewinds iid'
do
result
=
execute_service
expect
(
result
).
not_to
be_persisted
expect
(
internal_id
.
last_value
).
to
eq
(
1
)
end
expect
(
result
).
not_to
be_persisted
expect
(
internal_id
.
last_value
).
to
eq
(
0
)
end
end
end
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment