Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
5d0103eb
Commit
5d0103eb
authored
Sep 01, 2017
by
Stan Hu
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Use a button for the Geo Node "Advanced" link for accessibility
parent
f4e9be82
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
12 additions
and
14 deletions
+12
-14
app/assets/javascripts/geo_nodes.js
app/assets/javascripts/geo_nodes.js
+1
-1
app/assets/stylesheets/pages/geo_nodes.scss
app/assets/stylesheets/pages/geo_nodes.scss
+8
-9
app/views/admin/geo_nodes/index.html.haml
app/views/admin/geo_nodes/index.html.haml
+3
-4
No files found.
app/assets/javascripts/geo_nodes.js
View file @
5d0103eb
...
...
@@ -39,7 +39,7 @@ class GeoNodeStatus {
toggleShowAdvancedStatus
(
e
)
{
const
$element
=
$
(
e
.
currentTarget
);
const
$closestStatus
=
$element
.
closest
(
'
.advanced-geo-node-status-container
'
).
find
(
'
.advanced-status
'
)
const
$closestStatus
=
$element
.
siblings
(
'
.advanced-status
'
)
$element
.
find
(
'
.fa
'
).
toggleClass
(
'
fa-angle-down
'
).
toggleClass
(
'
fa-angle-up
'
);
$closestStatus
.
toggleClass
(
'
hidden
'
);
...
...
app/assets/stylesheets/pages/geo_nodes.scss
View file @
5d0103eb
...
...
@@ -29,16 +29,15 @@
}
}
.advanced-status-toggler
{
color
:
$gl-link-color
;
padding
:
10px
0
0
;
cursor
:
pointer
;
position
:
relative
;
display
:
inline-block
;
.advanced-geo-node-status-container
{
.btn-link
{
&
:hover
,
&
:focus
{
text-decoration
:
none
;
}
span
:hover
{
color
:
$gl-link-color
;
text-decoration
:
underline
;
span
:hover
{
text-decoration
:
underline
;
}
}
}
...
...
app/views/admin/geo_nodes/index.html.haml
View file @
5d0103eb
...
...
@@ -73,10 +73,9 @@
%span
.help-block
Last event ID processed by cursor:
%strong
.node-info.js-last-cursor-event
.advanced-status-toggler
.js-advanced-geo-node-status-toggler
%span
Advanced
=
icon
(
'angle-down'
)
%button
.btn-link.js-advanced-geo-node-status-toggler
%span
Advanced
=
icon
(
'angle-down'
)
%p
.js-health
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment