Merge branch 'sh-increase-issuable-limit' into 'master'

Raise issuable text limits

See merge request gitlab-org/gitlab!18605

app/models/concerns/issuable.rb

@@ -28,8 +28,8 @@ module Issuable
 
   TITLE_LENGTH_MAX = 255
   TITLE_HTML_LENGTH_MAX = 800
-  DESCRIPTION_LENGTH_MAX = 16000
-  DESCRIPTION_HTML_LENGTH_MAX = 48000
+  DESCRIPTION_LENGTH_MAX = 1.megabyte
+  DESCRIPTION_HTML_LENGTH_MAX = 5.megabytes
 
   # This object is used to gather issuable meta data for displaying
   # upvotes, downvotes, notes and closing merge requests count for issues and merge requests

doc/development/issuable-like-models.md

@@ -11,8 +11,8 @@ There are max length constraints for the most important text fields for `Issuabl
 
 - `title`: 255 chars
 - `title_html`: 800 chars
-- `description`: 16000 chars
-- `description_html`: 48000 chars
+- `description`: 1 megabyte
+- `description_html`: 5 megabytes
 
 [Issue]: https://docs.gitlab.com/ee/user/project/issues
 [Merge Requests]: https://docs.gitlab.com/ee/user/project/merge_requests

ee/spec/models/concerns/ee/issuable_spec.rb

@@ -14,8 +14,8 @@ describe EE::Issuable do
       it { is_expected.to validate_presence_of(:iid) }
       it { is_expected.to validate_presence_of(:author) }
       it { is_expected.to validate_presence_of(:title) }
-      it { is_expected.to validate_length_of(:title).is_at_most(255) }
-      it { is_expected.to validate_length_of(:description).is_at_most(16_000).on(:create) }
+      it { is_expected.to validate_length_of(:title).is_at_most(::Issuable::TITLE_LENGTH_MAX) }
+      it { is_expected.to validate_length_of(:description).is_at_most(::Issuable::DESCRIPTION_LENGTH_MAX).on(:create) }
 
       it_behaves_like 'validates description length with custom validation'
       it_behaves_like 'truncates the description to its allowed maximum length on import'

ee/spec/models/vulnerability_spec.rb

@@ -50,9 +50,9 @@ describe Vulnerability do
     it { is_expected.to validate_presence_of(:severity) }
     it { is_expected.to validate_presence_of(:confidence) }
 
-    it { is_expected.to validate_length_of(:title).is_at_most(255) }
-    it { is_expected.to validate_length_of(:title_html).is_at_most(800) }
-    it { is_expected.to validate_length_of(:description).is_at_most(16_000).allow_nil }
-    it { is_expected.to validate_length_of(:description_html).is_at_most(48_000).allow_nil }
+    it { is_expected.to validate_length_of(:title).is_at_most(::Issuable::TITLE_LENGTH_MAX) }
+    it { is_expected.to validate_length_of(:title_html).is_at_most(::Issuable::TITLE_HTML_LENGTH_MAX) }
+    it { is_expected.to validate_length_of(:description).is_at_most(::Issuable::DESCRIPTION_LENGTH_MAX).allow_nil }
+    it { is_expected.to validate_length_of(:description_html).is_at_most(::Issuable::DESCRIPTION_HTML_LENGTH_MAX).allow_nil }
   end
 end

spec/models/concerns/issuable_spec.rb

@@ -45,8 +45,8 @@ describe Issuable do
       it { is_expected.to validate_presence_of(:iid) }
       it { is_expected.to validate_presence_of(:author) }
       it { is_expected.to validate_presence_of(:title) }
-      it { is_expected.to validate_length_of(:title).is_at_most(255) }
-      it { is_expected.to validate_length_of(:description).is_at_most(16_000).on(:create) }
+      it { is_expected.to validate_length_of(:title).is_at_most(described_class::TITLE_LENGTH_MAX) }
+      it { is_expected.to validate_length_of(:description).is_at_most(described_class::DESCRIPTION_LENGTH_MAX).on(:create) }
 
       it_behaves_like 'validates description length with custom validation'
       it_behaves_like 'truncates the description to its allowed maximum length on import'

spec/support/shared_examples/models/concern/issuable_shared_examples.rb

@@ -10,7 +10,7 @@ shared_examples_for 'matches_cross_reference_regex? fails fast' do
 end
 
 shared_examples_for 'validates description length with custom validation' do
-  let(:issuable) { build(:issue, description: 'x' * 16_001) }
+  let(:issuable) { build(:issue, description: 'x' * (::Issuable::DESCRIPTION_LENGTH_MAX + 1)) }
   let(:context) { :update }
 
   subject { issuable.validate(context) }
@@ -18,7 +18,7 @@ shared_examples_for 'validates description length with custom validation' do
   context 'when Issuable is a new record' do
     it 'validates the maximum description length' do
       subject
-      expect(issuable.errors[:description]).to eq(["is too long (maximum is 16000 characters)"])
+      expect(issuable.errors[:description]).to eq(["is too long (maximum is #{::Issuable::DESCRIPTION_LENGTH_MAX} characters)"])
     end
 
     context 'on create' do
@@ -53,14 +53,14 @@ shared_examples_for 'truncates the description to its allowed maximum length on
     allow(issuable).to receive(:importing?).and_return(true)
   end
 
-  let(:issuable) { build(:issue, description: 'x' * 16_001) }
+  let(:issuable) { build(:issue, description: 'x' * (::Issuable::DESCRIPTION_LENGTH_MAX + 1)) }
 
   subject { issuable.validate(:create) }
 
   it 'truncates the description to its allowed maximum length' do
     subject
 
-    expect(issuable.description).to eq('x' * 16_000)
+    expect(issuable.description).to eq('x' * ::Issuable::DESCRIPTION_LENGTH_MAX)
     expect(issuable.errors[:description]).to be_empty
   end
 end