Merge branch 'pl-rubocop-inline-association-prometheus-alert' into 'master'

Fix cop FactoryBot/InlineAssociation for prometheus_alert

See merge request gitlab-org/gitlab!45526

.rubocop_todo.yml

@@ -1328,7 +1328,6 @@ FactoryBot/InlineAssociation:
     - 'spec/factories/notes.rb'
     - 'spec/factories/packages.rb'
     - 'spec/factories/packages/package_file.rb'
-    - 'spec/factories/prometheus_alert.rb'
     - 'spec/factories/resource_label_events.rb'
     - 'spec/factories/resource_milestone_event.rb'
     - 'spec/factories/resource_state_event.rb'

spec/factories/prometheus_alert.rb

@@ -7,11 +7,11 @@ FactoryBot.define do
     threshold { 1 }
 
     environment do |alert|
-      build(:environment, project: alert.project)
+      association(:environment, project: alert.project)
     end
 
     prometheus_metric do |alert|
-      build(:prometheus_metric, project: alert.project)
+      association(:prometheus_metric, project: alert.project)
     end
 
     trait :with_runbook_url do