Merge branch '229972-remove-health-status-incidents' into 'master'

Remove health status from incidents

See merge request gitlab-org/gitlab!40520

ee/app/models/concerns/health_status.rb

@@ -14,6 +14,7 @@ module HealthStatus
 
   override :supports_health_status?
   def supports_health_status?
+    return false if incident?
     return false unless resource_parent&.feature_available?(:issuable_health_status)
 
     ::Feature.enabled?(:save_issuable_health_status, resource_parent.try(:group), default_enabled: true)

ee/changelogs/unreleased/229972-remove-health-status-incidents.yml

+---
+title: Remove health status feature from incidents
+merge_request: 40520
+author:
+type: changed

ee/spec/models/concerns/health_status_spec.rb

+# frozen_string_literal: true
+
+require 'spec_helper'
+
+RSpec.describe HealthStatus do
+  describe '#supports_health_status?' do
+    using RSpec::Parameterized::TableSyntax
+
+    let(:project_with_group) { build_stubbed(:project, group: group, creator: creator) }
+    let(:group) { build_stubbed(:group) }
+    let(:creator) { build_stubbed(:user) }
+
+    before do
+      stub_licensed_features(issuable_health_status: issuable_health_status)
+      stub_feature_flags(save_issuable_health_status: save_issuable_health_status)
+    end
+
+    where(:issuable_type, :issuable_health_status, :save_issuable_health_status, :supports_health_status) do
+      :issue         | true  | true  | true
+      :issue         | false | false | false
+      :issue         | false | true  | false
+      :issue         | true  | false | false
+      :incident      | true  | true  | false
+      :incident      | false | false | false
+      :incident      | false | true  | false
+      :incident      | true  | false | false
+      :merge_request | true  | true  | false
+      :merge_request | false | false | false
+      :merge_request | false | true  | false
+      :merge_request | true  | false | false
+    end
+
+    with_them do
+      let(:issuable) { build_stubbed(issuable_type, project: project_with_group) }
+
+      subject { issuable.supports_health_status? }
+
+      it { is_expected.to eq(supports_health_status) }
+    end
+  end
+end