Commit 605796d6 authored by Peter Leitzen's avatar Peter Leitzen

Resolve RuboCop offenses in issues form feature specs

parent 6071fca1
...@@ -4,11 +4,10 @@ require 'spec_helper' ...@@ -4,11 +4,10 @@ require 'spec_helper'
RSpec.describe 'New/edit issue', :js do RSpec.describe 'New/edit issue', :js do
include ActionView::Helpers::JavaScriptHelper include ActionView::Helpers::JavaScriptHelper
include FormHelper
let_it_be(:project) { create(:project) } let_it_be(:project) { create(:project) }
let_it_be(:user) { create(:user)} let_it_be(:user) { create(:user) }
let_it_be(:user2) { create(:user)} let_it_be(:user2) { create(:user) }
let_it_be(:milestone) { create(:milestone, project: project) } let_it_be(:milestone) { create(:milestone, project: project) }
let_it_be(:label) { create(:label, project: project) } let_it_be(:label) { create(:label, project: project) }
let_it_be(:label2) { create(:label, project: project) } let_it_be(:label2) { create(:label, project: project) }
...@@ -22,7 +21,7 @@ RSpec.describe 'New/edit issue', :js do ...@@ -22,7 +21,7 @@ RSpec.describe 'New/edit issue', :js do
sign_in(user) sign_in(user)
end end
context 'new issue' do describe 'new issue' do
before do before do
visit new_project_issue_path(project) visit new_project_issue_path(project)
end end
...@@ -257,7 +256,9 @@ RSpec.describe 'New/edit issue', :js do ...@@ -257,7 +256,9 @@ RSpec.describe 'New/edit issue', :js do
end end
describe 'milestone' do describe 'milestone' do
let!(:milestone) { create(:milestone, title: '"><img src=x onerror=alert(document.domain)>', project: project) } let!(:milestone) do
create(:milestone, title: '"><img src=x onerror=alert(document.domain)>', project: project)
end
it 'escapes milestone' do it 'escapes milestone' do
click_button 'Milestone' click_button 'Milestone'
...@@ -274,7 +275,7 @@ RSpec.describe 'New/edit issue', :js do ...@@ -274,7 +275,7 @@ RSpec.describe 'New/edit issue', :js do
end end
end end
context 'edit issue' do describe 'edit issue' do
before do before do
visit edit_project_issue_path(project, issue) visit edit_project_issue_path(project, issue)
end end
...@@ -329,7 +330,7 @@ RSpec.describe 'New/edit issue', :js do ...@@ -329,7 +330,7 @@ RSpec.describe 'New/edit issue', :js do
end end
end end
context 'inline edit' do describe 'inline edit' do
before do before do
visit project_issue_path(project, issue) visit project_issue_path(project, issue)
end end
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment