Commit 6155d8e7 authored by Z.J. van de Weg's avatar Z.J. van de Weg

Update rubocop to ruby 2.3

parent ef7dd1e9
...@@ -5,7 +5,7 @@ require: ...@@ -5,7 +5,7 @@ require:
inherit_from: .rubocop_todo.yml inherit_from: .rubocop_todo.yml
AllCops: AllCops:
TargetRubyVersion: 2.1 TargetRubyVersion: 2.3
# Cop names are not d§splayed in offense messages by default. Change behavior # Cop names are not d§splayed in offense messages by default. Change behavior
# by overriding DisplayCopNames, or by giving the -D/--display-cop-names # by overriding DisplayCopNames, or by giving the -D/--display-cop-names
# option. # option.
......
...@@ -46,7 +46,7 @@ module KerberosSpnegoHelper ...@@ -46,7 +46,7 @@ module KerberosSpnegoHelper
return unless krb_principal return unless krb_principal
identity = ::Identity.find_by(provider: :kerberos, extern_uid: krb_principal) identity = ::Identity.find_by(provider: :kerberos, extern_uid: krb_principal)
identity.user if identity identity&.user
end end
# The Kerberos backend will translate spnego_token into a Kerberos # The Kerberos backend will translate spnego_token into a Kerberos
......
...@@ -152,7 +152,7 @@ class Notify < BaseMailer ...@@ -152,7 +152,7 @@ class Notify < BaseMailer
headers['In-Reply-To'] = message_id(model) headers['In-Reply-To'] = message_id(model)
headers['References'] = message_id(model) headers['References'] = message_id(model)
headers[:subject].prepend('Re: ') if headers[:subject] headers[:subject]&.prepend('Re: ')
mail_thread(model, headers) mail_thread(model, headers)
end end
......
...@@ -129,31 +129,25 @@ class ApplicationSetting < ActiveRecord::Base ...@@ -129,31 +129,25 @@ class ApplicationSetting < ActiveRecord::Base
numericality: { only_integer: true, greater_than_or_equal_to: 0 } numericality: { only_integer: true, greater_than_or_equal_to: 0 }
validates_each :restricted_visibility_levels do |record, attr, value| validates_each :restricted_visibility_levels do |record, attr, value|
unless value.nil? value&.each do |level|
value.each do |level| unless Gitlab::VisibilityLevel.options.has_value?(level)
unless Gitlab::VisibilityLevel.options.has_value?(level) record.errors.add(attr, "'#{level}' is not a valid visibility level")
record.errors.add(attr, "'#{level}' is not a valid visibility level")
end
end end
end end
end end
validates_each :import_sources do |record, attr, value| validates_each :import_sources do |record, attr, value|
unless value.nil? value&.each do |source|
value.each do |source| unless Gitlab::ImportSources.options.has_value?(source)
unless Gitlab::ImportSources.options.has_value?(source) record.errors.add(attr, "'#{source}' is not a import source")
record.errors.add(attr, "'#{source}' is not a import source")
end
end end
end end
end end
validates_each :disabled_oauth_sign_in_sources do |record, attr, value| validates_each :disabled_oauth_sign_in_sources do |record, attr, value|
unless value.nil? value&.each do |source|
value.each do |source| unless Devise.omniauth_providers.include?(source.to_sym)
unless Devise.omniauth_providers.include?(source.to_sym) record.errors.add(attr, "'#{source}' is not an OAuth sign-in source")
record.errors.add(attr, "'#{source}' is not an OAuth sign-in source")
end
end end
end end
end end
...@@ -255,11 +249,11 @@ class ApplicationSetting < ActiveRecord::Base ...@@ -255,11 +249,11 @@ class ApplicationSetting < ActiveRecord::Base
end end
def domain_whitelist_raw def domain_whitelist_raw
self.domain_whitelist.join("\n") unless self.domain_whitelist.nil? self.domain_whitelist&.join("\n")
end end
def domain_blacklist_raw def domain_blacklist_raw
self.domain_blacklist.join("\n") unless self.domain_blacklist.nil? self.domain_blacklist&.join("\n")
end end
def domain_whitelist_raw=(values) def domain_whitelist_raw=(values)
......
...@@ -98,8 +98,8 @@ module Issuable ...@@ -98,8 +98,8 @@ module Issuable
def update_assignee_cache_counts def update_assignee_cache_counts
# make sure we flush the cache for both the old *and* new assignees(if they exist) # make sure we flush the cache for both the old *and* new assignees(if they exist)
previous_assignee = User.find_by_id(assignee_id_was) if assignee_id_was previous_assignee = User.find_by_id(assignee_id_was) if assignee_id_was
previous_assignee.update_cache_counts if previous_assignee previous_assignee&.update_cache_counts
assignee.update_cache_counts if assignee assignee&.update_cache_counts
end end
# We want to use optimistic lock for cases when only title or description are involved # We want to use optimistic lock for cases when only title or description are involved
......
...@@ -73,7 +73,7 @@ module Milestoneish ...@@ -73,7 +73,7 @@ module Milestoneish
def memoize_per_user(user, method_name) def memoize_per_user(user, method_name)
@memoized ||= {} @memoized ||= {}
@memoized[method_name] ||= {} @memoized[method_name] ||= {}
@memoized[method_name][user.try!(:id)] ||= yield @memoized[method_name][user&.id] ||= yield
end end
# override in a class that includes this module to get a faster query # override in a class that includes this module to get a faster query
......
...@@ -126,7 +126,7 @@ class Environment < ActiveRecord::Base ...@@ -126,7 +126,7 @@ class Environment < ActiveRecord::Base
return unless available? return unless available?
stop! stop!
stop_action.play(current_user) if stop_action stop_action&.play(current_user)
end end
def actions_for(environment) def actions_for(environment)
......
...@@ -95,7 +95,7 @@ class GeoNode < ActiveRecord::Base ...@@ -95,7 +95,7 @@ class GeoNode < ActiveRecord::Base
end end
def update_dependents_attributes def update_dependents_attributes
self.geo_node_key.title = "Geo node: #{self.url}" if self.geo_node_key self.geo_node_key&.title = "Geo node: #{self.url}"
if self.primary? if self.primary?
self.oauth_application = nil self.oauth_application = nil
......
...@@ -9,7 +9,7 @@ class GroupMilestone < GlobalMilestone ...@@ -9,7 +9,7 @@ class GroupMilestone < GlobalMilestone
def self.build(group, projects, title) def self.build(group, projects, title)
super(projects, title).tap do |milestone| super(projects, title).tap do |milestone|
milestone.group = group if milestone milestone&.group = group
end end
end end
......
...@@ -945,9 +945,7 @@ class Repository ...@@ -945,9 +945,7 @@ class Repository
GitOperationService.new(user, self).with_branch( GitOperationService.new(user, self).with_branch(
target_branch) do |start_commit| target_branch) do |start_commit|
if merge_request merge_request&.update(in_progress_merge_commit_sha: their_commit.oid)
merge_request.update(in_progress_merge_commit_sha: their_commit.oid)
end
their_commit.oid their_commit.oid
end end
......
...@@ -334,7 +334,7 @@ class User < ActiveRecord::Base ...@@ -334,7 +334,7 @@ class User < ActiveRecord::Base
def find_by_personal_access_token(token_string) def find_by_personal_access_token(token_string)
personal_access_token = PersonalAccessToken.active.find_by_token(token_string) if token_string personal_access_token = PersonalAccessToken.active.find_by_token(token_string) if token_string
personal_access_token.user if personal_access_token personal_access_token&.user
end end
# Returns a user for the given SSH key. # Returns a user for the given SSH key.
......
...@@ -69,16 +69,12 @@ class WikiPage ...@@ -69,16 +69,12 @@ class WikiPage
# The raw content of this page. # The raw content of this page.
def content def content
@attributes[:content] ||= if @page @attributes[:content] ||= @page&.text_data
@page.text_data
end
end end
# The processed/formatted content of this page. # The processed/formatted content of this page.
def formatted_content def formatted_content
@attributes[:formatted_content] ||= if @page @attributes[:formatted_content] ||= @page&.formatted_data
@page.formatted_data
end
end end
# The markup format for the page. # The markup format for the page.
......
...@@ -4,7 +4,7 @@ class CreateTagService < BaseService ...@@ -4,7 +4,7 @@ class CreateTagService < BaseService
return error('Tag name invalid') unless valid_tag return error('Tag name invalid') unless valid_tag
repository = project.repository repository = project.repository
message.strip! if message message&.strip!
new_tag = nil new_tag = nil
......
...@@ -9,7 +9,7 @@ class DeleteTagService < BaseService ...@@ -9,7 +9,7 @@ class DeleteTagService < BaseService
if repository.rm_tag(current_user, tag_name) if repository.rm_tag(current_user, tag_name)
release = project.releases.find_by(tag: tag_name) release = project.releases.find_by(tag: tag_name)
release.destroy if release release&.destroy
push_data = build_push_data(tag) push_data = build_push_data(tag)
EventCreateService.new.push(project, current_user, push_data) EventCreateService.new.push(project, current_user, push_data)
......
...@@ -15,7 +15,7 @@ module Issues ...@@ -15,7 +15,7 @@ module Issues
def before_create(issuable) def before_create(issuable)
if @recaptcha_verified if @recaptcha_verified
spam_log = current_user.spam_logs.find_by(id: @spam_log_id, title: issuable.title) spam_log = current_user.spam_logs.find_by(id: @spam_log_id, title: issuable.title)
spam_log.update!(recaptcha_verified: true) if spam_log spam_log&.update!(recaptcha_verified: true)
else else
issuable.spam = spam_service.check(@api) issuable.spam = spam_service.check(@api)
issuable.spam_log = spam_service.spam_log issuable.spam_log = spam_service.spam_log
......
...@@ -107,7 +107,7 @@ module Projects ...@@ -107,7 +107,7 @@ module Projects
project.push_rule = push_rule project.push_rule = push_rule
end end
@project.group.refresh_members_authorized_projects if @project.group @project.group&.refresh_members_authorized_projects
end end
def skip_wiki? def skip_wiki?
......
...@@ -16,6 +16,6 @@ class AuthorizedProjectsWorker ...@@ -16,6 +16,6 @@ class AuthorizedProjectsWorker
def perform(user_id) def perform(user_id)
user = User.find_by(id: user_id) user = User.find_by(id: user_id)
user.refresh_authorized_projects if user user&.refresh_authorized_projects
end end
end end
...@@ -84,7 +84,7 @@ module API ...@@ -84,7 +84,7 @@ module API
branch = user_project.repository.find_branch(params[:branch]) branch = user_project.repository.find_branch(params[:branch])
not_found!("Branch") unless branch not_found!("Branch") unless branch
protected_branch = user_project.protected_branches.find_by(name: branch.name) protected_branch = user_project.protected_branches.find_by(name: branch.name)
protected_branch.destroy if protected_branch protected_branch&.destroy
present branch, with: Entities::RepoBranch, project: user_project present branch, with: Entities::RepoBranch, project: user_project
end end
......
...@@ -429,9 +429,7 @@ module API ...@@ -429,9 +429,7 @@ module API
expose :author, using: Entities::UserBasic, if: ->(event, options) { event.author } expose :author, using: Entities::UserBasic, if: ->(event, options) { event.author }
expose :author_username do |event, options| expose :author_username do |event, options|
if event.author event.author&.username
event.author.username
end
end end
end end
......
...@@ -58,7 +58,7 @@ module Gitlab ...@@ -58,7 +58,7 @@ module Gitlab
def helpers(*nodes) def helpers(*nodes)
nodes.each do |symbol| nodes.each do |symbol|
define_method("#{symbol}_defined?") do define_method("#{symbol}_defined?") do
@entries[symbol].specified? if @entries[symbol] @entries[symbol]&.specified?
end end
define_method("#{symbol}_value") do define_method("#{symbol}_value") do
......
...@@ -46,7 +46,7 @@ module Gitlab ...@@ -46,7 +46,7 @@ module Gitlab
end end
def diffs_count def diffs_count
diffs.size if diffs diffs&.size
end end
def compare def compare
...@@ -58,7 +58,7 @@ module Gitlab ...@@ -58,7 +58,7 @@ module Gitlab
end end
def compare_timeout def compare_timeout
diffs.overflow? if diffs diffs&.overflow?
end end
def reverse_compare? def reverse_compare?
......
...@@ -13,7 +13,7 @@ module Gitlab ...@@ -13,7 +13,7 @@ module Gitlab
end end
def data def data
lines.join("\n") if lines lines&.join("\n")
end end
def name def name
......
...@@ -112,7 +112,7 @@ module Gitlab ...@@ -112,7 +112,7 @@ module Gitlab
def self.tag_transaction(name, value) def self.tag_transaction(name, value)
trans = current_transaction trans = current_transaction
trans.add_tag(name, value) if trans trans&.add_tag(name, value)
end end
# Sets the action of the current transaction (if any) # Sets the action of the current transaction (if any)
...@@ -121,7 +121,7 @@ module Gitlab ...@@ -121,7 +121,7 @@ module Gitlab
def self.action=(action) def self.action=(action)
trans = current_transaction trans = current_transaction
trans.action = action if trans trans&.action = action
end end
# Tracks an event. # Tracks an event.
...@@ -130,7 +130,7 @@ module Gitlab ...@@ -130,7 +130,7 @@ module Gitlab
def self.add_event(*args) def self.add_event(*args)
trans = current_transaction trans = current_transaction
trans.add_event(*args) if trans trans&.add_event(*args)
end end
# Returns the prefix to use for the name of a series. # Returns the prefix to use for the name of a series.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment