Commit 61b58f2b authored by Coung Ngo's avatar Coung Ngo Committed by Simon Knox

Remove unnecessary html roles

Remove unnecessary html roles and also remove some
unnecessary tabindexes
parent 90d65ded
...@@ -79,7 +79,6 @@ export default { ...@@ -79,7 +79,6 @@ export default {
</script> </script>
<template> <template>
<article <article
role="article"
class="draft-note-component note-wrapper" class="draft-note-component note-wrapper"
@mouseenter="handleMouseEnter(draft)" @mouseenter="handleMouseEnter(draft)"
@mouseleave="handleMouseLeave(draft)" @mouseleave="handleMouseLeave(draft)"
......
...@@ -77,12 +77,7 @@ export default { ...@@ -77,12 +77,7 @@ export default {
</div> </div>
</template> </template>
<template v-else> <template v-else>
<gl-dropdown-item <gl-dropdown-item v-for="{ title } in items" :key="title" @click="$emit('selected', title)">
v-for="{ title } in items"
:key="title"
role="milestone option"
@click="$emit('selected', title)"
>
<span class="gl-pl-6" :class="{ 'selected-item': isSelectedMilestone(title) }"> <span class="gl-pl-6" :class="{ 'selected-item': isSelectedMilestone(title) }">
{{ title }} {{ title }}
</span> </span>
......
...@@ -146,7 +146,7 @@ export default { ...@@ -146,7 +146,7 @@ export default {
class="gl-display-flex gl-align-items-center gl-ml-2 gl-text-gray-500" class="gl-display-flex gl-align-items-center gl-ml-2 gl-text-gray-500"
:aria-label="__('Read more about related issues')" :aria-label="__('Read more about related issues')"
> >
<gl-icon name="question" :size="12" role="text" /> <gl-icon name="question" :size="12" />
</gl-link> </gl-link>
<div class="gl-display-inline-flex"> <div class="gl-display-inline-flex">
......
...@@ -133,14 +133,12 @@ export default { ...@@ -133,14 +133,12 @@ export default {
v-gl-tooltip v-gl-tooltip
:title="ideButtonTitle" :title="ideButtonTitle"
class="gl-display-none d-md-inline-block gl-mr-3" class="gl-display-none d-md-inline-block gl-mr-3"
:tabindex="!mr.canPushToSourceBranch ? 0 : null" :tabindex="ideButtonTitle ? 0 : null"
> >
<gl-button <gl-button
:href="webIdePath" :href="webIdePath"
:disabled="!mr.canPushToSourceBranch" :disabled="!mr.canPushToSourceBranch"
class="js-web-ide" class="js-web-ide"
tabindex="0"
role="button"
data-qa-selector="open_in_web_ide_button" data-qa-selector="open_in_web_ide_button"
> >
{{ s__('mrWidget|Open in Web IDE') }} {{ s__('mrWidget|Open in Web IDE') }}
......
...@@ -139,41 +139,33 @@ export default { ...@@ -139,41 +139,33 @@ export default {
<div class="ci-widget media"> <div class="ci-widget media">
<template v-if="hasCIError"> <template v-if="hasCIError">
<gl-icon name="status_failed" class="gl-text-red-500" :size="24" /> <gl-icon name="status_failed" class="gl-text-red-500" :size="24" />
<div <p class="gl-flex-fill-1 gl-ml-5 gl-mb-0" data-testid="ci-error-message">
class="gl-flex-fill-1 gl-ml-5"
tabindex="0"
role="text"
:aria-label="$options.errorText"
data-testid="ci-error-message"
>
<gl-sprintf :message="$options.errorText"> <gl-sprintf :message="$options.errorText">
<template #link="{ content }"> <template #link="{ content }">
<gl-link :href="mrTroubleshootingDocsPath">{{ content }}</gl-link> <gl-link :href="mrTroubleshootingDocsPath">{{ content }}</gl-link>
</template> </template>
</gl-sprintf> </gl-sprintf>
</div> </p>
</template> </template>
<template v-else-if="!hasPipeline"> <template v-else-if="!hasPipeline">
<gl-loading-icon size="md" /> <gl-loading-icon size="md" />
<div class="gl-flex-fill-1 gl-display-flex gl-ml-5" data-testid="monitoring-pipeline-message"> <p
<span tabindex="0" role="text" :aria-label="$options.monitoringPipelineText"> class="gl-flex-fill-1 gl-display-flex gl-ml-5 gl-mb-0"
<gl-sprintf :message="$options.monitoringPipelineText" /> data-testid="monitoring-pipeline-message"
</span> >
{{ $options.monitoringPipelineText }}
<gl-link <gl-link
:href="ciTroubleshootingDocsPath" :href="ciTroubleshootingDocsPath"
target="_blank" target="_blank"
class="gl-display-flex gl-align-items-center gl-ml-2" class="gl-display-flex gl-align-items-center gl-ml-2"
tabindex="0"
> >
<gl-icon <gl-icon
name="question" name="question"
:size="12" :size="12"
tabindex="0"
role="text"
:aria-label="__('Link to go to GitLab pipeline documentation')" :aria-label="__('Link to go to GitLab pipeline documentation')"
/> />
</gl-link> </gl-link>
</div> </p>
</template> </template>
<template v-else-if="hasPipeline"> <template v-else-if="hasPipeline">
<a :href="status.details_path" class="align-self-start gl-mr-3"> <a :href="status.details_path" class="align-self-start gl-mr-3">
......
...@@ -114,16 +114,15 @@ export default { ...@@ -114,16 +114,15 @@ export default {
</div> </div>
</button> </button>
</div> </div>
<div <section
v-show="isExpanded" v-show="isExpanded"
:id="contentContainerId" :id="contentContainerId"
ref="contentContainer" ref="contentContainer"
:aria-labelledby="buttonId" :aria-labelledby="buttonId"
role="region"
> >
<slot name="sub-title"></slot> <slot name="sub-title"></slot>
<div ref="content" :style="contentStyles"><slot name="default"></slot></div> <div ref="content" :style="contentStyles"><slot name="default"></slot></div>
</div> </section>
</template> </template>
<div v-else ref="loadingIndicator" class="d-flex p-2"> <div v-else ref="loadingIndicator" class="d-flex p-2">
<div class="h-32-px"> <div class="h-32-px">
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment