Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
628ab9f7
Commit
628ab9f7
authored
3 years ago
by
Florie Guibert
Committed by
Simon Knox
3 years ago
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix adding issue to newly created board list
changelog: fixed
parent
ff8fd0c8
No related merge requests found
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
44 additions
and
4 deletions
+44
-4
app/assets/javascripts/boards/components/board_list.vue
app/assets/javascripts/boards/components/board_list.vue
+11
-4
app/assets/javascripts/boards/components/board_list_deprecated.vue
...s/javascripts/boards/components/board_list_deprecated.vue
+7
-0
spec/features/boards/new_issue_spec.rb
spec/features/boards/new_issue_spec.rb
+26
-0
No files found.
app/assets/javascripts/boards/components/board_list.vue
View file @
628ab9f7
...
...
@@ -111,10 +111,17 @@ export default {
this
.
showCount
=
this
.
scrollHeight
()
>
Math
.
ceil
(
this
.
listHeight
());
});
},
},
created
()
{
eventHub
.
$on
(
`toggle-issue-form-
${
this
.
list
.
id
}
`
,
this
.
toggleForm
);
eventHub
.
$on
(
`scroll-board-list-
${
this
.
list
.
id
}
`
,
this
.
scrollToTop
);
'
list.id
'
:
{
handler
(
id
,
oldVal
)
{
if
(
id
)
{
eventHub
.
$on
(
`toggle-issue-form-
${
this
.
list
.
id
}
`
,
this
.
toggleForm
);
eventHub
.
$on
(
`scroll-board-list-
${
this
.
list
.
id
}
`
,
this
.
scrollToTop
);
eventHub
.
$off
(
`toggle-issue-form-
${
oldVal
}
`
,
this
.
toggleForm
);
eventHub
.
$off
(
`scroll-board-list-
${
oldVal
}
`
,
this
.
scrollToTop
);
}
},
immediate
:
true
,
},
},
beforeDestroy
()
{
eventHub
.
$off
(
`toggle-issue-form-
${
this
.
list
.
id
}
`
,
this
.
toggleForm
);
...
...
This diff is collapsed.
Click to expand it.
app/assets/javascripts/boards/components/board_list_deprecated.vue
View file @
628ab9f7
...
...
@@ -91,6 +91,13 @@ export default {
}
});
},
'
list.id
'
:
{
handler
(
id
)
{
if
(
id
)
{
eventHub
.
$on
(
`toggle-issue-form-
${
this
.
list
.
id
}
`
,
this
.
toggleForm
);
}
},
},
},
created
()
{
eventHub
.
$on
(
`toggle-issue-form-
${
this
.
list
.
id
}
`
,
this
.
toggleForm
);
...
...
This diff is collapsed.
Click to expand it.
spec/features/boards/new_issue_spec.rb
View file @
628ab9f7
...
...
@@ -120,6 +120,32 @@ RSpec.describe 'Issue Boards new issue', :js do
expect
(
page
).
to
have_content
'Label 1'
end
end
it
'allows creating an issue in newly created list'
do
click_button
'Create list'
wait_for_all_requests
click_button
'Select a label'
find
(
'label'
,
text:
label
.
title
).
click
click_button
'Add to board'
wait_for_all_requests
page
.
within
(
'.board:nth-child(2)'
)
do
click_button
(
'New issue'
)
page
.
within
(
first
(
'.board-new-issue-form'
))
do
find
(
'.form-control'
).
set
(
'new issue'
)
click_button
'Create issue'
end
wait_for_all_requests
page
.
within
(
'.board-card'
)
do
expect
(
page
).
to
have_content
'new issue'
end
end
end
end
context
'unauthorized user'
do
...
...
This diff is collapsed.
Click to expand it.
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment