Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
632f8b0a
Commit
632f8b0a
authored
Oct 05, 2018
by
Kamil Trzciński
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix CE to EE merge
parent
8e453d75
Changes
4
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
11 additions
and
10 deletions
+11
-10
app/services/merge_requests/refresh_service.rb
app/services/merge_requests/refresh_service.rb
+6
-5
ee/app/services/ee/merge_requests/refresh_service.rb
ee/app/services/ee/merge_requests/refresh_service.rb
+3
-3
ee/spec/helpers/application_helper_spec.rb
ee/spec/helpers/application_helper_spec.rb
+1
-1
lib/gitlab/git/push.rb
lib/gitlab/git/push.rb
+1
-1
No files found.
app/services/merge_requests/refresh_service.rb
View file @
632f8b0a
...
...
@@ -5,16 +5,17 @@ module MergeRequests
prepend
EE
::
MergeRequests
::
RefreshService
def
execute
(
oldrev
,
newrev
,
ref
)
@push
=
Gitlab
::
Git
::
Push
.
new
(
@project
,
oldrev
,
newrev
,
ref
)
push
=
Gitlab
::
Git
::
Push
.
new
(
@project
,
oldrev
,
newrev
,
ref
)
return
true
unless
push
.
branch_push?
return
true
unless
@push
.
branch_push?
refresh_merge_requests!
refresh_merge_requests!
(
push
)
end
private
def
refresh_merge_requests!
def
refresh_merge_requests!
(
push
)
@push
=
push
Gitlab
::
GitalyClient
.
allow_n_plus_1_calls
(
&
method
(
:find_new_commits
))
# Be sure to close outstanding MRs before reloading them to avoid generating an
# empty diff during a manual merge
...
...
ee/app/services/ee/merge_requests/refresh_service.rb
View file @
632f8b0a
...
...
@@ -5,9 +5,9 @@ module EE
private
override
:
do_execute
def
do_execute
(
oldrev
,
newrev
,
ref
)
super
&&
reset_approvals_for_merge_requests
(
ref
,
newrev
)
override
:
refresh_merge_requests!
def
refresh_merge_requests!
(
push
)
super
&&
reset_approvals_for_merge_requests
(
push
.
ref
,
push
.
newrev
)
end
# Note: Closed merge requests also need approvals reset.
...
...
ee/spec/helpers/application_helper_spec.rb
View file @
632f8b0a
...
...
@@ -24,7 +24,7 @@ describe ApplicationHelper do
let
(
:noteable_type
)
{
Issue
}
it
'returns paths for autocomplete_sources_controller'
do
expect_autocomplete_data_sources
(
object
,
noteable_type
,
[
:members
,
:issues
,
:mergeRequests
,
:labels
,
:milestones
,
:commands
])
expect_autocomplete_data_sources
(
object
,
noteable_type
,
[
:members
,
:issues
,
:mergeRequests
,
:labels
,
:milestones
,
:commands
,
:snippets
])
end
end
end
...
...
lib/gitlab/git/push.rb
View file @
632f8b0a
...
...
@@ -5,7 +5,7 @@ module Gitlab
class
Push
include
Gitlab
::
Utils
::
StrongMemoize
attr_reader
:oldrev
,
:newrev
attr_reader
:
ref
,
:
oldrev
,
:newrev
def
initialize
(
project
,
oldrev
,
newrev
,
ref
)
@project
=
project
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment