Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
63b5af9b
Commit
63b5af9b
authored
Aug 29, 2019
by
GitLab Bot
Browse files
Options
Browse Files
Download
Plain Diff
Automatic merge of gitlab-org/gitlab-ce master
parents
9f18e0ec
1c687f7f
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
22 additions
and
1 deletion
+22
-1
app/mailers/emails/issues.rb
app/mailers/emails/issues.rb
+1
-1
changelogs/unreleased/66524-issue-due-notification-emails-are-threaded-incorrectly.yml
...ssue-due-notification-emails-are-threaded-incorrectly.yml
+5
-0
spec/mailers/notify_spec.rb
spec/mailers/notify_spec.rb
+16
-0
No files found.
app/mailers/emails/issues.rb
View file @
63b5af9b
...
...
@@ -11,7 +11,7 @@ module Emails
def
issue_due_email
(
recipient_id
,
issue_id
,
reason
=
nil
)
setup_issue_mail
(
issue_id
,
recipient_id
)
mail_
new
_thread
(
@issue
,
issue_thread_options
(
@issue
.
author_id
,
recipient_id
,
reason
))
mail_
answer
_thread
(
@issue
,
issue_thread_options
(
@issue
.
author_id
,
recipient_id
,
reason
))
end
def
new_mention_in_issue_email
(
recipient_id
,
issue_id
,
updated_by_user_id
,
reason
=
nil
)
...
...
changelogs/unreleased/66524-issue-due-notification-emails-are-threaded-incorrectly.yml
0 → 100644
View file @
63b5af9b
---
title
:
Fix issue due notification emails not being threaded correctly
merge_request
:
32325
author
:
type
:
fixed
spec/mailers/notify_spec.rb
View file @
63b5af9b
...
...
@@ -187,6 +187,22 @@ describe Notify do
end
end
describe
'that are due soon'
do
subject
{
described_class
.
issue_due_email
(
recipient
.
id
,
issue
.
id
)
}
before
do
issue
.
update
(
due_date:
Date
.
tomorrow
)
end
it_behaves_like
'an answer to an existing thread with reply-by-email enabled'
do
let
(
:model
)
{
issue
}
end
it_behaves_like
'it should show Gmail Actions View Issue link'
it_behaves_like
'an unsubscribeable thread'
it_behaves_like
'appearance header and footer enabled'
it_behaves_like
'appearance header and footer not enabled'
end
describe
'status changed'
do
let
(
:status
)
{
'closed'
}
subject
{
described_class
.
issue_status_changed_email
(
recipient
.
id
,
issue
.
id
,
status
,
current_user
.
id
)
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment