Merge branch 'fix_create_table_with_two_foreign_keys_cop' into 'master'

Fix create table with two foreign keys cop

See merge request gitlab-org/gitlab!42131

rubocop/cop/migration/create_table_with_foreign_keys.rb

@@ -35,7 +35,7 @@ module RuboCop
           )
         PATTERN
 
-        def_node_search :argument_name, <<~PATTERN
+        def_node_matcher :argument_name?, <<~PATTERN
           {(sym $...) (str $...)}
         PATTERN
 
@@ -87,7 +87,11 @@ module RuboCop
         end
 
         def arguments_to_table_names(arguments)
-          arguments.flat_map { |argument| argument_name(argument).to_a.flatten.first.to_s.pluralize.to_sym }
+          arguments.select { |argument| argument_name?(argument) }
+                   .map(&:value)
+                   .map(&:to_s)
+                   .map(&:pluralize)
+                   .map(&:to_sym)
         end
       end
     end

spec/rubocop/cop/migration/create_table_with_foreign_keys_spec.rb

@@ -42,14 +42,28 @@ RSpec.describe RuboCop::Cop::Migration::CreateTableWithForeignKeys, type: :ruboc
     context 'with foreign key' do
       context 'with just one foreign key' do
         context 'when the foreign_key targets a high traffic table' do
-          it 'does not register any offenses' do
-            expect_no_offenses(<<~RUBY)
-              def up
-                create_table(:foo) do |t|
-                  t.references :project, "foreign_key" => { on_delete: 'cascade', to_table: 'projects' }
+          context 'when the foreign_key has to_table option set' do
+            it 'does not register any offenses' do
+              expect_no_offenses(<<~RUBY)
+                def up
+                  create_table(:foo) do |t|
+                    t.references :project, "foreign_key" => { on_delete: 'cascade', to_table: 'projects' }
+                  end
                 end
-              end
-            RUBY
+              RUBY
+            end
+          end
+
+          context 'when the foreign_key does not have to_table option set' do
+            it 'does not register any offenses' do
+              expect_no_offenses(<<~RUBY)
+                def up
+                  create_table(:foo) do |t|
+                    t.references :project, foreign_key: { on_delete: 'cascade' }
+                  end
+                end
+              RUBY
+            end
           end
         end