Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
6553d9b1
Commit
6553d9b1
authored
Nov 06, 2020
by
Florie Guibert
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Default boards_with_swimlanes feature flag to true
parent
2df95811
Changes
7
Hide whitespace changes
Inline
Side-by-side
Showing
7 changed files
with
15 additions
and
10 deletions
+15
-10
app/controllers/groups/boards_controller.rb
app/controllers/groups/boards_controller.rb
+1
-1
app/controllers/projects/boards_controller.rb
app/controllers/projects/boards_controller.rb
+1
-1
app/views/shared/boards/_show.html.haml
app/views/shared/boards/_show.html.haml
+1
-1
app/views/shared/issuable/_search_bar.html.haml
app/views/shared/issuable/_search_bar.html.haml
+1
-1
config/feature_flags/development/boards_with_swimlanes.yml
config/feature_flags/development/boards_with_swimlanes.yml
+5
-5
ee/app/graphql/resolvers/board_groupings/epics_resolver.rb
ee/app/graphql/resolvers/board_groupings/epics_resolver.rb
+1
-1
ee/changelogs/unreleased/238222-default-boards-with-swimlanes-ff-to-true.yml
...eased/238222-default-boards-with-swimlanes-ff-to-true.yml
+5
-0
No files found.
app/controllers/groups/boards_controller.rb
View file @
6553d9b1
...
@@ -8,7 +8,7 @@ class Groups::BoardsController < Groups::ApplicationController
...
@@ -8,7 +8,7 @@ class Groups::BoardsController < Groups::ApplicationController
before_action
:assign_endpoint_vars
before_action
:assign_endpoint_vars
before_action
do
before_action
do
push_frontend_feature_flag
(
:graphql_board_lists
,
group
,
default_enabled:
false
)
push_frontend_feature_flag
(
:graphql_board_lists
,
group
,
default_enabled:
false
)
push_frontend_feature_flag
(
:boards_with_swimlanes
,
group
,
default_enabled:
fals
e
)
push_frontend_feature_flag
(
:boards_with_swimlanes
,
group
,
default_enabled:
tru
e
)
end
end
feature_category
:boards
feature_category
:boards
...
...
app/controllers/projects/boards_controller.rb
View file @
6553d9b1
...
@@ -8,7 +8,7 @@ class Projects::BoardsController < Projects::ApplicationController
...
@@ -8,7 +8,7 @@ class Projects::BoardsController < Projects::ApplicationController
before_action
:authorize_read_board!
,
only:
[
:index
,
:show
]
before_action
:authorize_read_board!
,
only:
[
:index
,
:show
]
before_action
:assign_endpoint_vars
before_action
:assign_endpoint_vars
before_action
do
before_action
do
push_frontend_feature_flag
(
:boards_with_swimlanes
,
project
,
default_enabled:
fals
e
)
push_frontend_feature_flag
(
:boards_with_swimlanes
,
project
,
default_enabled:
tru
e
)
end
end
feature_category
:boards
feature_category
:boards
...
...
app/views/shared/boards/_show.html.haml
View file @
6553d9b1
...
@@ -17,7 +17,7 @@
...
@@ -17,7 +17,7 @@
=
render
'shared/issuable/search_bar'
,
type: :boards
,
board:
board
=
render
'shared/issuable/search_bar'
,
type: :boards
,
board:
board
#board-app
.boards-app.position-relative
{
"v-cloak"
=>
"true"
,
data:
board_data
,
":class"
=>
"{ 'is-compact': detailIssueVisible }"
}
#board-app
.boards-app.position-relative
{
"v-cloak"
=>
"true"
,
data:
board_data
,
":class"
=>
"{ 'is-compact': detailIssueVisible }"
}
-
if
Feature
.
enabled?
(
:boards_with_swimlanes
,
current_board_parent
)
||
Feature
.
enabled?
(
:graphql_board_lists
,
current_board_parent
)
-
if
Feature
.
enabled?
(
:boards_with_swimlanes
,
current_board_parent
,
default_enabled:
true
)
||
Feature
.
enabled?
(
:graphql_board_lists
,
current_board_parent
)
%board-content
{
"v-cloak"
=>
"true"
,
%board-content
{
"v-cloak"
=>
"true"
,
"ref"
=>
"board_content"
,
"ref"
=>
"board_content"
,
":lists"
=>
"state.lists"
,
":lists"
=>
"state.lists"
,
...
...
app/views/shared/issuable/_search_bar.html.haml
View file @
6553d9b1
...
@@ -182,7 +182,7 @@
...
@@ -182,7 +182,7 @@
=
render
'shared/issuable/board_create_list_dropdown'
,
board:
board
=
render
'shared/issuable/board_create_list_dropdown'
,
board:
board
-
if
@project
-
if
@project
#js-add-issues-btn
.gl-ml-3
{
data:
{
can_admin_list:
can?
(
current_user
,
:admin_list
,
@project
)
}
}
#js-add-issues-btn
.gl-ml-3
{
data:
{
can_admin_list:
can?
(
current_user
,
:admin_list
,
@project
)
}
}
-
if
current_user
&&
Feature
.
enabled?
(
:boards_with_swimlanes
,
@group
)
-
if
current_user
&&
Feature
.
enabled?
(
:boards_with_swimlanes
,
@group
,
default_enabled:
true
)
#js-board-epics-swimlanes-toggle
#js-board-epics-swimlanes-toggle
#js-toggle-focus-btn
#js-toggle-focus-btn
-
elsif
is_not_boards_modal_or_productivity_analytics
&&
show_sorting_dropdown
-
elsif
is_not_boards_modal_or_productivity_analytics
&&
show_sorting_dropdown
...
...
config/feature_flags/development/boards_with_swimlanes.yml
View file @
6553d9b1
---
---
name
:
boards_with_swimlanes
name
:
boards_with_swimlanes
introduced_by_url
:
introduced_by_url
:
https://gitlab.com/gitlab-org/gitlab/-/issues/218040
rollout_issue_url
:
rollout_issue_url
:
https://gitlab.com/gitlab-org/gitlab/-/issues/238222
milestone
:
milestone
:
13.6
group
:
group::product planning
type
:
development
type
:
development
group
:
group::project management
default_enabled
:
true
default_enabled
:
false
ee/app/graphql/resolvers/board_groupings/epics_resolver.rb
View file @
6553d9b1
...
@@ -16,7 +16,7 @@ module Resolvers
...
@@ -16,7 +16,7 @@ module Resolvers
def
resolve
(
**
args
)
def
resolve
(
**
args
)
return
Epic
.
none
unless
board
.
present?
return
Epic
.
none
unless
board
.
present?
return
Epic
.
none
unless
group
.
present?
return
Epic
.
none
unless
group
.
present?
return
unless
::
Feature
.
enabled?
(
:boards_with_swimlanes
,
group
)
return
unless
::
Feature
.
enabled?
(
:boards_with_swimlanes
,
group
,
default_enabled:
true
)
context
.
scoped_set!
(
:board
,
board
)
context
.
scoped_set!
(
:board
,
board
)
...
...
ee/changelogs/unreleased/238222-default-boards-with-swimlanes-ff-to-true.yml
0 → 100644
View file @
6553d9b1
---
title
:
Epics Swimlanes for group and project issue boards
merge_request
:
47036
author
:
type
:
added
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment