Rename many path_with_namespace -> full_path

app/services/projects/slack_application_install_service.rb

@@ -19,7 +19,7 @@ module Projects
         service_id: service.id,
         team_id: slack_data['team_id'],
         team_name: slack_data['team_name'],
-        alias: project.path_with_namespace,
+        alias: project.full_path,
         user_id: slack_data['user_id']
       )
 

features/steps/groups_management.rb

@@ -51,7 +51,7 @@ class Spinach::Features::GroupsManagement < Spinach::FeatureSteps
     end
     page.within '.sub-nav' do
       find('a', text: 'General').trigger('click')
-    end    
+    end
   end
 
   step 'I enable membership lock' do
@@ -65,7 +65,7 @@ class Spinach::Features::GroupsManagement < Spinach::FeatureSteps
       click_link 'Projects'
     end
 
-    link = "/#{@project.path_with_namespace}/project_members"
+    link = "/#{@project.full_path}/project_members"
     find(:xpath, "//a[@href=\"#{link}\"]").click
   end
 

spec/models/project_spec.rb

@@ -2192,15 +2192,15 @@ describe Project do
       let!(:project2) { create(:project) }
 
       it 'returns the projects matching the paths' do
-        projects = described_class.where_full_path_in([project1.path_with_namespace,
-                                                       project2.path_with_namespace])
+        projects = described_class.where_full_path_in([project1.full_path,
+                                                       project2.full_path])
 
         expect(projects).to contain_exactly(project1, project2)
       end
 
       it 'returns projects regardless of the casing of paths' do
-        projects = described_class.where_full_path_in([project1.path_with_namespace.upcase,
-                                                       project2.path_with_namespace.upcase])
+        projects = described_class.where_full_path_in([project1.full_path.upcase,
+                                                       project2.full_path.upcase])
 
         expect(projects).to contain_exactly(project1, project2)
       end

spec/services/merge_requests/squash_service_spec.rb

@@ -161,7 +161,7 @@ describe MergeRequests::SquashService do
       end
 
       it 'logs the MR reference and exception' do
-        expect(service).to receive(:log_error).with(a_string_including("#{project.path_with_namespace}#{merge_request.to_reference}"))
+        expect(service).to receive(:log_error).with(a_string_including("#{project.full_path}#{merge_request.to_reference}"))
         expect(service).to receive(:log_error).with(error)
 
         service.execute(merge_request)

spec/services/slash_commands/global_slack_handler_spec.rb

@@ -37,10 +37,10 @@ describe SlashCommands::GlobalSlackHandler do
       enable_slack_application(project)
 
       slack_integration = create(:slack_integration, service: project.gitlab_slack_application_service)
-      slack_integration.update(alias: project.path_with_namespace)
+      slack_integration.update(alias: project.full_path)
 
       handler_with_valid_token(
-        text: "#{project.path_with_namespace} issue new title",
+        text: "#{project.full_path} issue new title",
         team_id: slack_integration.team_id
       ).trigger
     end
@@ -66,10 +66,10 @@ describe SlashCommands::GlobalSlackHandler do
       enable_slack_application(project)
 
       slack_integration = create(:slack_integration, service: project.gitlab_slack_application_service)
-      slack_integration.update(alias: project.path_with_namespace)
+      slack_integration.update(alias: project.full_path)
 
       handler_with_valid_token(
-        text: "#{project.path_with_namespace} issue new title",
+        text: "#{project.full_path} issue new title",
         team_id: slack_integration.team_id
       ).trigger
     end